Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Change tab URL calculation for contentblockerrules.js and surrogates.…
…js (#1021) <!-- Note: This checklist is a reminder of our shared engineering expectations. --> Please review the release process for BrowserServicesKit [here](https://app.asana.com/0/1200194497630846/1200837094583426). **Required**: Task/Issue URL: #1019 and https://app.asana.com/0/1200437802575119/1208550540369943/f iOS PR: TODO macOS PR: TODO What kind of version bump will this require?: Minor **Optional**: Tech Design URL: CC: **Description**: This PR changes the tab calculation for the page, currently it doesn't account for grand child frames at all. This code has mostly been cribbed from: https://github.com/duckduckgo/content-scope-scripts/blob/655d12d9e77f93cc36875142aa2ff3e06c52608d/injected/src/utils.js#L135-L157 Full disclosure: I tested this manually in the console rather than doing a full build, we should verify before releasing. Thanks to @alisha for spotting this problem in #1019, producing a well written explanation and PR! **Steps to test this PR**: For testing the blocking follow the steps in: #1019 using the console. For surrogates the same should work for a tracker on the surrogate list: - replacing https://rtb.openx.net/openrtbb/prebidjs with https://google-analytics.com/gtm/js - validating that frame has the script executed: cframe.contentWindow.ga should be defined <!-- Before submitting a PR, please ensure you have tested the combinations you expect the reviewer to test, then delete configurations you *know* do not need explicit testing. Using a simulator where a physical device is unavailable is acceptable. --> **OS Testing**: * [ ] iOS 14 * [ ] iOS 15 * [ ] iOS 16 * [ ] macOS 10.15 * [ ] macOS 11 * [ ] macOS 12 --- ###### Internal references: [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943)
- Loading branch information