Entitlements cache fixes (#736)

* Lower the default cache validity time to 1h * In case of lack of entitlements clear the cache instead of storing empty array
duckduckgo · Mar 20, 2024 · 1ba3e36 · 1ba3e36
1 parent 05e3446
commit 1ba3e36
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/Sources/Subscription/AccountManager.swift b/Sources/Subscription/AccountManager.swift
@@ -242,8 +242,13 @@ public class AccountManager: AccountManaging {
         switch await AuthService.validateToken(accessToken: accessToken) {
         case .success(let response):
             let entitlements = response.account.entitlements
+
             if entitlements != cachedEntitlements {
-                entitlementsCache.set(entitlements)
+                if entitlements.isEmpty {
+                    entitlementsCache.reset()
+                } else {
+                    entitlementsCache.set(entitlements)
+                }
                 NotificationCenter.default.post(name: .entitlementsDidChange, object: self, userInfo: [UserDefaultsCacheKey.subscriptionEntitlements: entitlements])
             }
             return .success(entitlements)

diff --git a/Sources/Subscription/UserDefaultsCache.swift b/Sources/Subscription/UserDefaultsCache.swift
@@ -24,7 +24,7 @@ public struct UserDefaultsCacheSettings {
     // Default expiration interval set to 24 hours
     public let defaultExpirationInterval: TimeInterval
 
-    public init(defaultExpirationInterval: TimeInterval = 24 * 60 * 60) {
+    public init(defaultExpirationInterval: TimeInterval = 1 * 60 * 60) {
         self.defaultExpirationInterval = defaultExpirationInterval
     }
 }