Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New file version of .ddf file #214

Open
XiaohangJi opened this issue Mar 7, 2024 · 2 comments
Open

New file version of .ddf file #214

XiaohangJi opened this issue Mar 7, 2024 · 2 comments

Comments

@XiaohangJi
Copy link

Please add this file version read, thank you! It is .ddf file, Software version number: ORYX F/W v4.00 Oryx Data Collector v3.7.3
Archive.zip

BSchilperoort added a commit that referenced this issue Apr 13, 2024
@BSchilperoort
Copy link
Collaborator

Hi, thanks for opening this issue. I'm sorry that it took a while to reply but I have (sadly) moved on from using DTS so I can't spend much time on it at the moment.

It seems like there is an issue with the code here:

if double_ended_flag:
if not flip_reverse_measurements:
# fiber length how the backward channel is aligned
fiber_length_raw = float(meta["fibre end"])
fiber_bw_1_index = np.abs(xraw - fiber_length_raw).argmin()
fiber_bw_end_index = np.min(
[xraw.size, fiber_bw_1_index + (fiber_end_index - fiber_1_index)]
)
fiber_bw_start_index = np.max(
[0, fiber_bw_1_index - fiber_n_indices - fiber_n_indices_internal]
)
REV_ST = REV_ST[fiber_bw_start_index:fiber_bw_end_index]
REV_AST = REV_AST[fiber_bw_start_index:fiber_bw_end_index]

It infers the fiber lengths incorrectly, making the backward channel measurements shorter than the forward temperature measurements.

I have implemented a quick solution in 3.0.1 which should resolve your loading issues. I'll leave this issue open so a proper fix can be implemented later.

BSchilperoort added a commit that referenced this issue Apr 13, 2024
* Patch issue #214

* Fix bumpversion config

* Bump version: 3.0.0 → 3.0.1

* Fix linter

* Transpose after loading in files

* Ensure correct dim order for every data loader

* Fix resample test: xr.resample will reorder dims
@BSchilperoort
Copy link
Collaborator

The new version is online, you should be able to do pip install dtscalibration==3.0.2 and load in your files!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants