Trees don't follow symlink unless explicitly enabled #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Watching a tree containing a symlink to '/' adds a watch to the whole file system, which is probably unwanted. To avoid such behavior by default, following symlinks has to be enabled explicitly. The code may still be vulnerable to TOCTOU. Further changes: * Use `os.walk()` to traverse the tree to watch * Remove duplicate `add_watch()` for `IN_MOVED_TO` * flake8 * Warn instead of failing hard if adding a watch in a tree fails. Can be, for example, a permission error.
|
About the older Python versions: Are they still relevant? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Watching a tree containing a symlink to '/' adds a watch to the whole file system, which is probably unwanted. To avoid such behavior by default, following symlinks has to be enabled explicitly. The code may still be vulnerable to TOCTOU.
Further changes:
os.walk()to traverse the tree to watchadd_watch()forIN_MOVED_TO