Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window Preview Size to Monitor Size Ratio fails to take into consideration display scaling on Wayland #212

Closed
FelixFourcolor opened this issue Dec 25, 2023 · 11 comments

Comments

@FelixFourcolor
Copy link

FelixFourcolor commented Dec 25, 2023

The property allows values from 0 to 1. However, if the display scaling is 200%, the value only goes up to 0.5; you can set it above 0.5, but it will be rendered the same as 0.5. And similarly if the display scaling is 300%, the value only goes up to 0.33.

This bug is only seen on Wayland.


Gnome 45
Extension v.70

@dsheeler
Copy link
Owner

Hey thanks for the report! I'll look into this like now because I'm on holiday with nothing to do. Is this a new thing? Or seen in previous versions too?

@FelixFourcolor
Copy link
Author

If I remember correctly v.70 just came out today? Then I'm sure it's also in v.69, but I can't remember before that.

@dsheeler
Copy link
Owner

Yes, v70 just today. Thanks!

@FelixFourcolor
Copy link
Author

FelixFourcolor commented Dec 27, 2023

It seems that this behavior is also app-dependent. Most apps behave as I described above, but I found that vscode and steam are scaled properly.

To exaggerate the effect I show Window Preview Size to Monitor Size Ratio=1 and display scaling 300%.

Screencast.from.2023-12-27.12-34-55.webm

@dsheeler
Copy link
Owner

dsheeler commented Jan 8, 2024

duplicate of #184

@dsheeler
Copy link
Owner

dsheeler commented Jan 8, 2024

@FelixFourcolor, I don't fully understand the situation. It might be that xwayland apps don't work but native wayland apps do or vice versa. Or something more complicated, like some xwayland apps work and some don't...

@FelixFourcolor
Copy link
Author

@dsheeler I didn't think about it, but that makes sense. I think xwayland apps are scaled correctly, only native ones are broken.

@FelixFourcolor
Copy link
Author

FelixFourcolor commented Jun 3, 2024

@dsheeler any updates on this bug? It still bugs me to this day.

@dsheeler
Copy link
Owner

dsheeler commented Jun 3, 2024

No updates, sorry. My last comment still describes my state of understanding which is my understanding is incomplete. I feared it was the case that it's up to the application to scale properly in xwayland and I couldn't really do anything about it. I forget what the app needs to do at this point. I also find it hard to get motivated because I sitll use X11 and this is a "temporary" problem that exists only as long as xwayland is necessary. But how long will that be???

@FelixFourcolor
Copy link
Author

Unless I misinterpreted what you said, I think you got it the other way around. It's native wayland apps that don't scale properly, xwayland apps work.

@dsheeler
Copy link
Owner

I'm going to close this one in favor of #184 of which this is a duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants