-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UpdateServicesComputerTargetGroup: New resource - managing computer target groups #78
base: main
Are you sure you want to change the base?
Conversation
Hey, @johlju. Trying to rebase per our discussion in #60. However the tests are failing for resources that I'm not touching, in a way that I haven't seen before - all saying ' Cannot find the Windows PowerShell data file 'MSFT_UpdateServicesApprovalRule.strings.psd1' in directory xxx' but the files they reference seem to appear in the module - feels like this is unrelated to my pull request. Can you advise? I guess I may also need to update the pester tests for v5 similar to #74 but I think this issue needs resolving first. |
Will have a look as soon as I have time. |
@johlju Quick reminder when you have a few minutes to check out the issue with the tests here :) |
@Borgquite if you wouldn't mind reviewing PR #79 so I can merge it, then this PR should be able to run the tests again after it has been rebased. 🙂 |
I merged PR #79 so this one can be rebased. |
…into ComputerTargetGroups
Thanks - I'll see if I can get the tests to resolve myself now, will keep you posted! |
f4d54a7
to
2011471
Compare
Ping me when the tests passes on this one, I will try to get the time to review. 🙂 |
Thanks - doing some fairly major reworking of the rest of UpdateServicesDsc (it's missing tonnes of useful parameters, breaks a lot of DSC 'rules' from my PoV, e.g. as others have noted, certain parameters take effect even when they are 'unspecified') and it generally just needs some love. I'll keep you posted. |
Pull Request (PR) description
A rebased pull for #60
It looks OK to me, waiting to see if it passes the Pester tests as these may need updating to support 5
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is