Reviewed 3 of 8 files at r1, all commit messages.
Reviewable status: 3 of 8 files reviewed, 6 unresolved discussions (waiting on @bbonaby)

CHANGELOG.md line 10 at r1 (raw file):

## [6.0.1] - 2024-06-11

### Changed

Also include the change to VirtualHardDisk

source/DSCResources/DSC_Disk/README.md line 39 at r1 (raw file):

This is a low-level concept that most users will never need to interact with but
for further reading, see the documentation [here](https://learn.microsoft.com/windows/dev-drive/#how-do-i-configure-additional-filters-on-dev-drive)
for further reading. In order to create a Dev Drive your configuration must run with

One of the for further reading's can be removed

Code quote:

for further reading.

source/DSCResources/DSC_Disk/en-US/DSC_Disk.strings.psd1 line 55 at r1 (raw file):

    TheVolumeIsNotConfiguredAsADevDriveVolume = The volume with path '{0}' and Drive letter '{1}' is not configured as a Dev Drive volume.
    TheVolumeIsCurrentlyConfiguredAsADevDriveVolume = The volume with path '{0}' and Drive letter '{1}' is currently configured as a Dev Drive volume.
    DevDriveAdminError = Creating a Dev Drive volume requires running local Administrator permissions. Please ensure this resource is being applied with an account with local Administrator permissions.

Can you add an id to the new entry Localization (dsccommunity.org).

source/Modules/StorageDsc.Common/StorageDsc.Common.psm1 line 638 at r1 (raw file):

        A user friendly error message specific to the caller.
#>
function Assert-ElevatedUserWithCustomErrorMessage

I wonder if it's worth extending Assert-ElevatedUser to accept a custom error message. @johlju thoughts?

source/Modules/StorageDsc.Common/StorageDsc.Common.psm1 line 656 at r1 (raw file):

    {
        # Use a user friendly error message specific to the caller
        throw $CustomErrorMessage

Need to not use throw and use ThrowTerminatingError e.g. in Assert-ElevatedUser.

That will depend on the overall strategy for this function though.

tests/Unit/DSC_Disk.Tests.ps1 line 713 at r1 (raw file):

        }

        function Assert-ElevatedUserWithCustomErrorMessageWithCustomErrorMessage

Adding a stub function here should not be required as it lives in this module.