Reopened and have reviewed.

Reviewed 1 of 4 files at r1, all commit messages.
Reviewable status: 1 of 4 files reviewed, 8 unresolved discussions (waiting on @claudiospizzi and @github-code-scanning[bot])

a discussion (no related file):
The unit tests need to be added that tests this change.

source/DSCResources/DSC_SqlProtocolTcpIp/DSC_SqlProtocolTcpIp.psm1 line 545 at r1 (raw file):

    $IpAddressGroup = Find-IpAddressGroup -IpAddressGroup $IpAddressGroup -InstanceName $InstanceName

    $IpAddressGroup = Convert-IpAdressGroupCasing -IpAddressGroup $IpAddressGroup

This should not be needed in the Test-TargetResource function since it calls Compare-function that calls Get-function. Get-function will sort this out. 🤔

Code quote:

    $IpAddressGroup = Find-IpAddressGroup -IpAddressGroup $IpAddressGroup -InstanceName $InstanceName

    $IpAddressGroup = Convert-IpAdressGroupCasing -IpAddressGroup $IpAddressGroup

source/DSCResources/DSC_SqlProtocolTcpIp/DSC_SqlProtocolTcpIp.psm1 line 770 at r1 (raw file):

        The IP address already stored in an IP address group.
#>
function Find-IpAddressGroup

We should make this a public command Find--SqlDscManagedComputerServerProtocolIpAddressGroup. See other comments as well.

source/DSCResources/DSC_SqlProtocolTcpIp/DSC_SqlProtocolTcpIp.psm1 line 782 at r1 (raw file):

        [Parameter(Mandatory = $true)]
        [AllowEmptyString()]

The IP Group can never be empty so this should be removed.

Code quote:

[AllowEmptyString()]

source/DSCResources/DSC_SqlProtocolTcpIp/DSC_SqlProtocolTcpIp.psm1 line 796 at r1 (raw file):

        )

        Import-SqlDscPreferredModule

This should not be needed as it done when SqlServerDsc is imported (which will be done when the public command is used). We should be able to remove this. See next comment too.

Code quote:

Import-SqlDscPreferredModule

source/DSCResources/DSC_SqlProtocolTcpIp/DSC_SqlProtocolTcpIp.psm1 line 808 at r1 (raw file):

        }

        $serverProtocolProperties = Get-ServerProtocolObject @getServerProtocolObjectParameters

We should make this a public command Get-SqlDscManagedComputerServerProtocol (that also resuses Get-SqlDscManagedComputer). See command Get-SqlDscManagedComputerService for example how the new command should work. The command Get-ServerProtocolObject can be kept also and be switched to the new public command in other PR's.

Code quote:

Get-ServerProtocolObject