Remove upfront extension requires #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses an issue where we were requiring all extension files upfront, which could raise errors if the required gems were not present in the user's environment. To resolve this, we've removed the automatic requires for ActiveRecord and ROM extensions from lib/dry/operation.rb. Instead, we've updated the documentation in both ActiveRecord and ROM extension files to include the necessary require statement in the example code. To ensure our tests continue to pass with these changes, we've also added the requires to the spec_helper file. See report: 92cdde9#commitcomment-146824502
waiting-for-dev
referenced
this pull request
Sep 17, 2024
waiting-for-dev
deleted the
waiting-for-dev/fix_requiring_extensions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This commit addresses an issue where we were requiring all extension files upfront, which could raise errors if the required gems were not present in the user's environment. To resolve this, we've removed the automatic requires for ActiveRecord and ROM extensions from lib/dry/operation.rb.
Instead, we've updated the documentation in both ActiveRecord and ROM extension files to include the necessary require statement in the example code. To ensure our tests continue to pass with these changes, we've also added the requires to the spec_helper file.
See report: 92cdde9#commitcomment-146824502
Screenshots/Screencasts
Details