Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The GraphQL language negotiation method is unusable with caching turned on #1152

Open
hchonov opened this issue Jan 30, 2021 · 0 comments · May be fixed by #1153
Open

The GraphQL language negotiation method is unusable with caching turned on #1152

hchonov opened this issue Jan 30, 2021 · 0 comments · May be fixed by #1153
Labels
4.x bug

Comments

@hchonov
Copy link

hchonov commented Jan 30, 2021

Currently the operation events are being fired only when retrieving executing an uncached operation. When retriving a cache entry in a multilingual setup it will contain a cache context for the content language. If the operation events are not fired then we cannot set the language in the execution context and therefore the language negotiation method will not be able to return anything. In order to solve the issue the operation events have to be called always before and after an operation even if reading from a cache entry.
hchonov added a commit to hchonov/graphql that referenced this issue Jan 30, 2021
@hchonov
drupal-graphql#1152 - fire the operation events before after retrievi…
3841ce8 
…ng a query result even if it is cached
@hchonov hchonov linked a pull request Jan 30, 2021 that will close this issue
Open
hchonov added a commit to hchonov/graphql that referenced this issue Feb 6, 2021
@hchonov
drupal-graphql#1152 - consider cache contexts for the cache prefix
a436bf9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4.x bug
Projects
None yet
Milestone
No milestone
2 participants
@Kingdutch @hchonov