Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slashes in current branch name being replaced with backslashes on windows #231

Open
ehrenberger-jan opened this issue Jul 24, 2023 · 1 comment

Comments

@ehrenberger-jan
Copy link

Hello.
In this commit there has been an update to the RealCommandRunner#executeAndParse method, in order to map file names 'to os specific path'. Which works fine in this case, however the same method is used in CommitShaProviders to detect the current branch name. As the branch name gets replaced from i.e. feature/abc to feature\abc, the next git command - finding the commit sha - fails the execution. So this mapping to os specific path should happen depending on the use case, possibly just moved to GitClientImpl#findChangedFiles.

Thank you for looking into this.

Best regards
Jan

@mezpahlan
Copy link
Contributor

Hi @ehrenberger-jan I think you're referring to the ForkCommit and SpecifiedBranchCommitMergeBase CommitShaProviders?

Apologies I introduced the changes you're referring to but didn't test with branches that contained slashes. I also don't have a Windows machine anymore 😞 so can't easily reproduce. I'll see if I can create a patch for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants