You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello.
In this commit there has been an update to the RealCommandRunner#executeAndParse method, in order to map file names 'to os specific path'. Which works fine in this case, however the same method is used in CommitShaProviders to detect the current branch name. As the branch name gets replaced from i.e. feature/abc to feature\abc, the next git command - finding the commit sha - fails the execution. So this mapping to os specific path should happen depending on the use case, possibly just moved to GitClientImpl#findChangedFiles.
Thank you for looking into this.
Best regards
Jan
The text was updated successfully, but these errors were encountered:
Hi @ehrenberger-jan I think you're referring to the ForkCommit and SpecifiedBranchCommitMergeBaseCommitShaProviders?
Apologies I introduced the changes you're referring to but didn't test with branches that contained slashes. I also don't have a Windows machine anymore 😞 so can't easily reproduce. I'll see if I can create a patch for this.
Hello.
In this commit there has been an update to the
RealCommandRunner#executeAndParse
method, in order to map file names 'to os specific path'. Which works fine in this case, however the same method is used in CommitShaProviders to detect the current branch name. As the branch name gets replaced from i.e.feature/abc
tofeature\abc
, the next git command - finding the commit sha - fails the execution. So this mapping to os specific path should happen depending on the use case, possibly just moved toGitClientImpl#findChangedFiles
.Thank you for looking into this.
Best regards
Jan
The text was updated successfully, but these errors were encountered: