Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CustomTask should use Gradle's NamedDomainObjectContainer or NamedDomainObjectSet #161

Open
vlsi opened this issue Aug 17, 2022 · 1 comment
Open

CustomTask should use Gradle's NamedDomainObjectContainer or NamedDomainObjectSet #161

vlsi opened this issue Aug 17, 2022 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@vlsi
Copy link

vlsi commented Aug 17, 2022

See https://github.com/dropbox/AffectedModuleDetector/pull/130/files#diff-6b5be434aa24824fb2973ce77a9dcda484db988e76842f367fb289129851c318R44

var customTasks = emptySet<AffectedModuleConfiguration.CustomTask>() would be better migrated to DomainObject APIs.
Here's a relevant article: https://blog.mrhaki.com/2016/02/gradle-goodness-create-objects-with-dsl.html
@vlsi vlsi mentioned this issue Aug 17, 2022
Merged
@Evleaps
Copy link
Contributor

Evleaps commented Aug 31, 2022

Hey! Thank you! I do it later.

@joshafeinberg joshafeinberg added the help wanted Extra attention is needed label Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vlsi @joshafeinberg @Evleaps