Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid specifier should return an error #92

Open
nsoblath opened this issue Mar 13, 2023 · 1 comment
Open

Invalid specifier should return an error #92

nsoblath opened this issue Mar 13, 2023 · 1 comment
Assignees

Comments

@nsoblath
Copy link
Member

Expected behavior for when a specifier is not handled should be that an error (i.e. 310) is returned. Right now that's not checked except for in Python with CMD requests, where if there's no function matching the specifier name, that error is returned.

@nsoblath nsoblath self-assigned this Mar 13, 2023
@nsoblath
Copy link
Member Author

nsoblath commented Sep 4, 2024

To get a little more specific:

  • endpoint: cmd's are explicitly not handled; nothing to do here
  • hub: return code in cmd handling isn't right; fix to return code 310 (dl_service_error_invalid_specifier()) here:
    return a_request->reply( dl_service_error_bad_payload(), "Instruction <" + t_instruction + "> not understood" );;
  • service: doesn't reimplement do_cmd_request(), so nothing to do here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant