SipDialogController: Protect against glare during reINVITE #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davehorton
reviewed
Dec 19, 2024
orgads
force-pushed
the
session-expires-glare-crash
branch
from
b1eac6d to
d9c682c
Compare
Scenario: Session-Expires with refresher=uas When client receives re-INVITE, it immediately sends BYE, and only then it responds with 481 to the INVITE. This results in drachtio crash. Fixes drachtio#401
orgads
force-pushed
the
session-expires-glare-crash
branch
from
d9c682c to
4071735
Compare
davehorton
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scenario:
Session-Expires with refresher=uas
When client receives re-INVITE, it immediately sends BYE, and only then it responds with 481 to the INVITE.
This results in drachtio crash.
Fixes #401