Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version tag to be referenced by pre-commit #8

Open
b1ackviking opened this issue Apr 6, 2021 · 2 comments
Open

Add version tag to be referenced by pre-commit #8

b1ackviking opened this issue Apr 6, 2021 · 2 comments

Comments

@b1ackviking
Copy link

When I try to use the hook as described in the readme, pre-commit issues the following warning message:

[WARNING] The 'rev' field of repo 'https://github.com/doublify/pre-commit-clang-format'
          appears to be a mutable reference (moving tag / branch). 
          Mutable references are never updated after first install and are not supported. 
          See https://pre-commit.com/#using-the-latest-version-for-a-repository for more details.

This basically means that using rev: master is wrong.

Although the hook does not seem to be frequently updated, it is sad to see this warning every time I commit. I suggest adding a 1.0 tag to the current HEAD of the repository.

@henryiii
Copy link

You can also just put an commit SHA here. But yes, pre-commit caches assuming the rev will never change, so you should never use master/main.

@okainov
Copy link

okainov commented Jul 21, 2021

+1 here, would be helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants