Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use supported version of gem state_machine #321

Open
compwron opened this issue May 18, 2019 · 1 comment
Open

use supported version of gem state_machine #321

compwron opened this issue May 18, 2019 · 1 comment
Labels
maintenance-updates Work to make sure that the app keeps up to date with language and dependencies

Comments

@compwron
Copy link
Member

I did some looking around, and here are my notes so far:
The current version we are using is the specific git commit seuros/state_machine@95ba53f The arooo commit message is "Switch to less abanadoned version of state_machine gem - But this is only a step toward actually being on the maintained version, but can't do that till we get on Rails 4.2"

I read the thread on pluginaweek/state_machine#310 (the original, now unmaintained gem) and it sounds like https://github.com/state-machines/state_machines (maintained by sauros) is the current most maintained fork. I tried all the versions published at https://rubygems.org/gems/state_machines/versions but I get the error ERROR: null value in column "state" violates not-null constraint in all our tests.

I'm not yet confident whether this is a real problem or just a problem with test setup- in order to figure this out I'll

  1. start up the server and do some manual testing locally
  2. check the data in prod to make sure we don't have null status column values
@compwron
Copy link
Member Author

compwron commented Jun 1, 2019

There are no users with empty state in prod

Loading production environment (Rails 4.2.11.1)
irb(main):001:0> User.where(state: nil)
=> #<ActiveRecord::Relation []>

@compwron compwron added the maintenance-updates Work to make sure that the app keeps up to date with language and dependencies label Jun 15, 2019
@brittag brittag added this to Arooo Jun 16, 2024
@brittag brittag moved this to To do in Arooo Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance-updates Work to make sure that the app keeps up to date with language and dependencies
Projects
Status: To do
Development

No branches or pull requests

1 participant