Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change vocabulary interface #92

Open
torymur opened this issue Nov 18, 2024 · 0 comments
Open

Change vocabulary interface #92

torymur opened this issue Nov 18, 2024 · 0 comments
Assignees
@torymur
Labels
documentation Improvements or additions to documentation enhancement New feature or request testing

Comments

@torymur
Copy link
Contributor

torymur commented Nov 18, 2024

Vocabulary interface requires adjustments:

  • its current interface needs to be corrected and properly tested
  • token type needs to be switched from String to bytes of Vec<u8> type, so that improvements from Create vocabulary from pretrained models #91 will be allowed to be integrated into Vocabulary

This work might affect Index interface too, see if it would be possible to split it into a separate Issue/PR.
@torymur torymur added documentation Improvements or additions to documentation enhancement New feature or request testing labels Nov 18, 2024
@torymur torymur self-assigned this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@torymur torymur

Labels
documentation Improvements or additions to documentation enhancement New feature or request testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@torymur