Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support connection to json_schema bindings from outlines #82

Open
torymur opened this issue Oct 24, 2024 · 1 comment
Open

Support connection to json_schema bindings from outlines #82

torymur opened this issue Oct 24, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@torymur
Copy link
Contributor

torymur commented Oct 24, 2024

What behavior of the library made you think about the improvement?

We have json_schema parsing logic available.

How would you like it to behave?

Outlines suppose to use these exposed python bindings:

  • build_regex_from_schema
  • to_regex

Related issue in outlines: dottxt-ai/outlines#1227

Also potential of uniting these into one could be investigated.
Some additional python code might be required, unclear yet from which side.
Maybe some additional tests.

@torymur torymur added the enhancement New feature or request label Oct 24, 2024
@rlouf
Copy link
Member

rlouf commented Oct 28, 2024

The first thing to do is to confirm that the logic is exactly the same (check whether they share the same tests). If that's the case we can update Outlines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants