Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/aspnetcore #45347

Merged
merged 14 commits into from
Dec 12, 2024
Merged

[main] Update dependencies from dotnet/aspnetcore #45347

merged 14 commits into from
Dec 12, 2024
+80 −51

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Dec 6, 2024 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/aspnetcore

  • Subscription: 4491d9a4-839d-4af5-f3e4-08d8e97c775d
  • Build: 20241211.1
  • Date Produced: December 11, 2024 10:46:10 AM UTC
  • Commit: 61be94cbcb4726afaa107f91c349fc4328263b44
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/aspnetcore build 2…
878c1bd 
…0241205.9

dotnet-dev-certs , dotnet-user-jwts , dotnet-user-secrets , Microsoft.AspNetCore.Analyzers , Microsoft.AspNetCore.App.Ref , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components.SdkAnalyzers , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.DeveloperCertificates.XPlat , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.FileProviders.Embedded , Microsoft.Extensions.ObjectPool , Microsoft.JSInterop , VS.Redist.Common.AspNetCore.SharedFramework.x64.10.0 , Microsoft.SourceBuild.Intermediate.aspnetcore
 From Version 10.0.0-alpha.2.24605.2 -> To Version 10.0.0-alpha.2.24605.9
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels Dec 6, 2024
@dotnet-maestro DotNet Maestro
Copy link
Contributor Author

dotnet-maestro bot commented Dec 6, 2024

Notification for subscribed users from https://github.com/dotnet/aspnetcore:

@dotnet/aspnet-build

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/aspnetcore) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

This was referenced Dec 6, 2024
Open
Open
@dotnet-maestro
Update dependencies from https://github.com/dotnet/aspnetcore build 2…
5e8f425 
…0241206.1

dotnet-dev-certs , dotnet-user-jwts , dotnet-user-secrets , Microsoft.AspNetCore.Analyzers , Microsoft.AspNetCore.App.Ref , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components.SdkAnalyzers , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.DeveloperCertificates.XPlat , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.FileProviders.Embedded , Microsoft.Extensions.ObjectPool , Microsoft.JSInterop , VS.Redist.Common.AspNetCore.SharedFramework.x64.10.0 , Microsoft.SourceBuild.Intermediate.aspnetcore
 From Version 10.0.0-alpha.2.24605.2 -> To Version 10.0.0-alpha.2.24606.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/aspnetcore build 2…
73cbacb 
…0241206.4

dotnet-dev-certs , dotnet-user-jwts , dotnet-user-secrets , Microsoft.AspNetCore.Analyzers , Microsoft.AspNetCore.App.Ref , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components.SdkAnalyzers , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.DeveloperCertificates.XPlat , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.FileProviders.Embedded , Microsoft.Extensions.ObjectPool , Microsoft.JSInterop , VS.Redist.Common.AspNetCore.SharedFramework.x64.10.0 , Microsoft.SourceBuild.Intermediate.aspnetcore
 From Version 10.0.0-alpha.2.24605.2 -> To Version 10.0.0-alpha.2.24606.4
@build-analysis build-analysis bot mentioned this pull request Dec 6, 2024
Open
@dotnet-maestro
Update dependencies from https://github.com/dotnet/aspnetcore build 2…
0a9c1ba 
…0241206.8

dotnet-dev-certs , dotnet-user-jwts , dotnet-user-secrets , Microsoft.AspNetCore.Analyzers , Microsoft.AspNetCore.App.Ref , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components.SdkAnalyzers , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.DeveloperCertificates.XPlat , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.FileProviders.Embedded , Microsoft.Extensions.ObjectPool , Microsoft.JSInterop , VS.Redist.Common.AspNetCore.SharedFramework.x64.10.0 , Microsoft.SourceBuild.Intermediate.aspnetcore
 From Version 10.0.0-alpha.2.24605.2 -> To Version 10.0.0-alpha.2.24606.8
@dotnet-maestro
Update dependencies from https://github.com/dotnet/aspnetcore build 2…
83df04e 
…0241207.1

dotnet-dev-certs , dotnet-user-jwts , dotnet-user-secrets , Microsoft.AspNetCore.Analyzers , Microsoft.AspNetCore.App.Ref , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components.SdkAnalyzers , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.DeveloperCertificates.XPlat , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.FileProviders.Embedded , Microsoft.Extensions.ObjectPool , Microsoft.JSInterop , VS.Redist.Common.AspNetCore.SharedFramework.x64.10.0 , Microsoft.SourceBuild.Intermediate.aspnetcore
 From Version 10.0.0-alpha.2.24605.2 -> To Version 10.0.0-alpha.2.24607.1
@ViktorHofer
Copy link
Member

@jkoritzinsky PTAL:

artifacts/sb/src/src/Installer/redist-installer/targets/GenerateLayout.targets(397,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Download from all targets failed. List of attempted targets: https://dotnetcli.blob.core.windows.net/dotnet/aspnetcore/Runtime/10.0.0-alpha.2.24607.1/aspnetcore-runtime-10.0.0-alpha.2.24607.1-linux-x64.tar.gz, https://dotnetbuilds.blob.core.windows.net/public/aspnetcore/Runtime/10.0.0-alpha.2.24607.1/aspnetcore-runtime-10.0.0-alpha.2.24607.1-linux-x64.tar.gz

dotnet_install: Error: Could not find ASP.NET Core Runtime with version = 10.0.0-alpha.2.24607.1

@ViktorHofer ViktorHofer mentioned this pull request Dec 9, 2024
Open
@ViktorHofer
Copy link
Member

ViktorHofer commented Dec 9, 2024 •
edited
Loading

Looks like at least linux archives are missing (only the -arm and linux-musl variants get produced):

image

@dotnet-maestro
Update dependencies from https://github.com/dotnet/aspnetcore build 2…
964791c 
…0241208.1

dotnet-dev-certs , dotnet-user-jwts , dotnet-user-secrets , Microsoft.AspNetCore.Analyzers , Microsoft.AspNetCore.App.Ref , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components.SdkAnalyzers , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.DeveloperCertificates.XPlat , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.FileProviders.Embedded , Microsoft.Extensions.ObjectPool , Microsoft.JSInterop , VS.Redist.Common.AspNetCore.SharedFramework.x64.10.0 , Microsoft.SourceBuild.Intermediate.aspnetcore
 From Version 10.0.0-alpha.2.24605.2 -> To Version 10.0.0-alpha.2.24608.1
@build-analysis build-analysis bot mentioned this pull request Dec 9, 2024
Open
@jkoritzinsky
Copy link
Member

Looks like I broke the post-build-sign logic when making sure the in-build-sign logic worked... I'll get that fixed (and the VMR failures as well).

@jkoritzinsky jkoritzinsky mentioned this pull request Dec 9, 2024
Merged
@dotnet-maestro
Update dependencies from https://github.com/dotnet/aspnetcore build 2…
5599940 
…0241209.1

dotnet-dev-certs , dotnet-user-jwts , dotnet-user-secrets , Microsoft.AspNetCore.Analyzers , Microsoft.AspNetCore.App.Ref , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components.SdkAnalyzers , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.DeveloperCertificates.XPlat , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.FileProviders.Embedded , Microsoft.Extensions.ObjectPool , Microsoft.JSInterop , VS.Redist.Common.AspNetCore.SharedFramework.x64.10.0 , Microsoft.SourceBuild.Intermediate.aspnetcore
 From Version 10.0.0-alpha.2.24605.2 -> To Version 10.0.0-alpha.2.24609.1
@ViktorHofer ViktorHofer mentioned this pull request Dec 10, 2024
Merged
@dotnet-maestro
Update dependencies from https://github.com/dotnet/aspnetcore build 2…
ec7a8d9 
…0241210.1

dotnet-dev-certs , dotnet-user-jwts , dotnet-user-secrets , Microsoft.AspNetCore.Analyzers , Microsoft.AspNetCore.App.Ref , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components.SdkAnalyzers , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.DeveloperCertificates.XPlat , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.FileProviders.Embedded , Microsoft.Extensions.ObjectPool , Microsoft.JSInterop , VS.Redist.Common.AspNetCore.SharedFramework.x64.10.0 , Microsoft.SourceBuild.Intermediate.aspnetcore
 From Version 10.0.0-alpha.2.24605.2 -> To Version 10.0.0-alpha.2.24610.1
@ViktorHofer
Copy link
Member

@jkoritzinsky next one:

/vmr/.dotnet/sdk/10.0.100-alpha.1.24555.54/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(90,5): error NETSDK1094: (NETCORE_ENGINEERING_TELEMETRY=Restore) Unable to optimize assemblies for performance: a valid runtime package was not found. Either set the PublishReadyToRun property to false, or use a supported runtime identifier when publishing. When targeting .NET 6 or higher, make sure to restore packages with the PublishReadyToRun property set to true.

@jkoritzinsky
Copy link
Member

Looks like this is falling into the same problem as the "crossgen for cross build" problem. Here's what's happening:

  1. The SDK we're building with has a rid of linux-x64 (from $(NETCoreSdkRuntimeIdentifier)) and a portable RID of linux-x64 (from $(NETCoreSdkPortableRuntimeIdentifier)).
  2. We're targeting centos.9-x64 in the source-build build.
  3. Because centos.9-x64 isn't the same RID as the SDK's non-portable RID, we the SDK looks for Microsoft.NETCore.App.Crossgen2.linux-x64, as it knows that can run on the host machine.

This is the same problem as the "cross-build on crossgen2" problem, but in this subcase we could hack it together to make it work since we know that we're doing a source-build.

To unblock this, I can disable R2Ring on source-build here since we need to solve the general crossgen2 problem for the VMR.

@jkoritzinsky jkoritzinsky requested review from a team as code owners December 10, 2024 19:36
@dotnet-maestro
Update dependencies from https://github.com/dotnet/aspnetcore build 2…
eeb80dc 
…0241210.3

dotnet-dev-certs , dotnet-user-jwts , dotnet-user-secrets , Microsoft.AspNetCore.Analyzers , Microsoft.AspNetCore.App.Ref , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components.SdkAnalyzers , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.DeveloperCertificates.XPlat , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.FileProviders.Embedded , Microsoft.Extensions.ObjectPool , Microsoft.JSInterop , VS.Redist.Common.AspNetCore.SharedFramework.x64.10.0 , Microsoft.SourceBuild.Intermediate.aspnetcore
 From Version 10.0.0-alpha.2.24605.2 -> To Version 10.0.0-alpha.2.24610.3
@dotnet-maestro
Update dependencies from https://github.com/dotnet/aspnetcore build 2…
9747444 
…0241210.6

dotnet-dev-certs , dotnet-user-jwts , dotnet-user-secrets , Microsoft.AspNetCore.Analyzers , Microsoft.AspNetCore.App.Ref , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components.SdkAnalyzers , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.DeveloperCertificates.XPlat , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.FileProviders.Embedded , Microsoft.Extensions.ObjectPool , Microsoft.JSInterop , VS.Redist.Common.AspNetCore.SharedFramework.x64.10.0 , Microsoft.SourceBuild.Intermediate.aspnetcore
 From Version 10.0.0-alpha.2.24605.2 -> To Version 10.0.0-alpha.2.24610.6
@dotnet-maestro
Update dependencies from https://github.com/dotnet/aspnetcore build 2…
234a12f 
…0241210.7

dotnet-dev-certs , dotnet-user-jwts , dotnet-user-secrets , Microsoft.AspNetCore.Analyzers , Microsoft.AspNetCore.App.Ref , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components.SdkAnalyzers , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.DeveloperCertificates.XPlat , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.FileProviders.Embedded , Microsoft.Extensions.ObjectPool , Microsoft.JSInterop , VS.Redist.Common.AspNetCore.SharedFramework.x64.10.0 , Microsoft.SourceBuild.Intermediate.aspnetcore
 From Version 10.0.0-alpha.2.24605.2 -> To Version 10.0.0-alpha.2.24610.7
@dotnet-maestro
Update dependencies from https://github.com/dotnet/aspnetcore build 2…
a658a75 
…0241211.1

dotnet-dev-certs , dotnet-user-jwts , dotnet-user-secrets , Microsoft.AspNetCore.Analyzers , Microsoft.AspNetCore.App.Ref , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components.SdkAnalyzers , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.DeveloperCertificates.XPlat , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.FileProviders.Embedded , Microsoft.Extensions.ObjectPool , Microsoft.JSInterop , VS.Redist.Common.AspNetCore.SharedFramework.x64.10.0 , Microsoft.SourceBuild.Intermediate.aspnetcore
 From Version 10.0.0-alpha.2.24605.2 -> To Version 10.0.0-alpha.2.24611.1
@jkoritzinsky
Copy link
Member

@ViktorHofer we finally got this green! Can you review my changes and merge?

@jkoritzinsky jkoritzinsky enabled auto-merge (squash) December 12, 2024 05:04
@jkoritzinsky jkoritzinsky merged commit 873df55 into main Dec 12, 2024
42 checks passed
@jkoritzinsky jkoritzinsky deleted the darc-main-bf495d97-04ff-48ff-a815-df0d9a071e4c branch December 12, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees
No one assigned
Labels
Area-CodeFlow untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ViktorHofer @jkoritzinsky