Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate LanguageServiceErrorListProvider's behavior of "zero'ing" negative and zero column and line numbers #145

Open
davkean opened this issue May 15, 2016 · 0 comments
Open

Investigate LanguageServiceErrorListProvider's behavior of "zero'ing" negative and zero column and line numbers #145

davkean opened this issue May 15, 2016 · 0 comments
Assignees
@davkean
Labels
Parity-Legacy-Feature Missing features from the legacy project system. Triage-Investigate Reviewed and investigation needed by dev team
Milestone
Backlog

Comments

@davkean
Copy link
Member

davkean commented May 15, 2016 •
edited
Loading

LanguageServiceErrorListProvider's adjusts by lines and column's by -1, to account for the Error List's 0-based indexing, but could result in strange behavior:

All these three column/lines numbers will get passed to Roslyn as "0":

-1 => 0
0 => 0
1 => 0

Need to figure out if this accidently puts line/column numbers on errors/warnings that don't have any.
@davkean davkean added Parity-Legacy-Feature Missing features from the legacy project system. Bug labels May 15, 2016
@davkean davkean added this to the 1.0 (Preview 3) milestone May 15, 2016
@srivatsn srivatsn modified the milestones: 1.0 (Preview 3), 1.0 (RTM) May 24, 2016
@srivatsn srivatsn modified the milestones: 1.0 RTM, 1.1 Jan 27, 2017
@srivatsn srivatsn modified the milestones: 16.0, 15.3 Apr 3, 2017
@jjmew jjmew modified the milestones: 16.0, 16.X Feb 13, 2019
eric62369 pushed a commit to eric62369/project-system that referenced this issue Jul 10, 2020
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20190…
4355e1a 
…628.2 (dotnet#145)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19328.2
@jjmew jjmew added this to the Backlog milestone Oct 20, 2020
@jjmew jjmew added the Triage-Investigate Reviewed and investigation needed by dev team label Oct 20, 2020
@drewnoakes drewnoakes removed the Bug label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davkean davkean

Labels
Parity-Legacy-Feature Missing features from the legacy project system. Triage-Investigate Reviewed and investigation needed by dev team
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@srivatsn @drewnoakes @davkean @jjmew