Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve linked file rename experience #100

Open
davkean opened this issue May 13, 2016 · 3 comments
Open

Improve linked file rename experience #100

davkean opened this issue May 13, 2016 · 3 comments
Labels
Triage-Approved Reviewed and prioritized
Milestone

Comments

@davkean
Copy link
Member

davkean commented May 13, 2016

From @tmat on March 24, 2016 19:22

When renaming a file that is a target of one or more links the links should be updated. Currently, after the rename all links are broken. To fix them one needs to unload projects and manually change the links or remove and add the links again.

Copied from original issue: dotnet/roslyn#10076

@davkean
Copy link
Member Author

davkean commented May 13, 2016

From @tamlin-mike on March 27, 2016 14:20

"links" is a devious word, and this is a non-obvious problem.

What if you have a source file/class "Bar", but decide "Nah, I want this to be "BarBase", while intending to (re-) create "Bar" after that change, to inherit from BarBase.

This is just one possible scenario, but a possibility.

Perhaps a question would be better; Do you want to auto-convert/adjust .... (granted, opening for the possibility there will be pointers to "nothing") rather than silently than auto-convert any and all references?

Just a thought.

(the next person calling this an "Experience" I will send a null-pointer to)

@davkean
Copy link
Member Author

davkean commented May 13, 2016

From @tmat on March 27, 2016 16:30

@tamlin-mike I don't think the scenario you describe isn't as common as just renaming the file. You can still achieve that by simply Ctrl+A and cut & paste the content of the Bar into the new file BarBase.

What I want is a similar experience to Inline Rename on a symbol.

@davkean
Copy link
Member Author

davkean commented May 13, 2016

From @birbilis on May 8, 2016 17:42

Does this system cover solution files too or just project files? Currently when I have a Diagrams solution folder in my Solution and multiple .CD (class diagram) files from projects in that solution dropped into that folder (this makes links to the original items), when I rename a class diagram in one of the projects, I have to remove the link from the Diagrams folder in the solution and add it again

@srivatsn srivatsn modified the milestone: Unknown May 24, 2016
@jjmew jjmew added Triage-Approved Reviewed and prioritized and removed Triage-Approved Reviewed and prioritized labels Jan 14, 2019
@jmarolf jmarolf self-assigned this Jul 10, 2019
@drewnoakes drewnoakes changed the title Project System: Improve linked file rename experience Improve linked file rename experience Apr 5, 2020
@jmarolf jmarolf removed their assignment May 21, 2020
eric62369 pushed a commit to eric62369/project-system that referenced this issue Jul 10, 2020
…513.3 (dotnet#100)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19263.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Triage-Approved Reviewed and prioritized
Projects
None yet
Development

No branches or pull requests

5 participants