Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot is creating duplicate "new API" comments #77

Open
stephentoub opened this issue Jun 11, 2024 · 2 comments
Open

Bot is creating duplicate "new API" comments #77

stephentoub opened this issue Jun 11, 2024 · 2 comments

Comments

@stephentoub
Copy link
Member

e.g.
dotnet/runtime#103308 (comment)

Image

@ericstj
Copy link
Member

ericstj commented Jun 11, 2024

I can repro with the test endpoint of the webhook controller - this will add 2 comments - so it's not a case of github calling the webhook too many times.

I suspect that this commentOn method is retrying https://github.com/dotnet/issue-labeler/blob/0571c524404b80334144e365a4449bb111565ceb/src/GitHubHelpers/GitHubClientWrapper.cs#L77C22-L77C42

@ericstj
Copy link
Member

ericstj commented Jun 11, 2024

I tested that theory by enabling logs for the app service and triggering the test endpoint. I didn't observe a failure in the log (which I would expect for a retry here) so either it's not retrying - or the log is set up correctly for this component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants