Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer repo should explore using arcade tasks for msi generation #12101

Open
mmitche opened this issue Sep 23, 2021 · 2 comments
Open

Installer repo should explore using arcade tasks for msi generation #12101

mmitche opened this issue Sep 23, 2021 · 2 comments
Milestone

Comments

@mmitche
Copy link
Member

mmitche commented Sep 23, 2021

The installer repo uses a series of powershell scripts for msi generation right now. These then have to be kept in line with the light command package drop creation (if inputs change). They're also generally hard to understand (from a command line standpoint) since they pull in about 20 unnamed parameters. For example:

    <Exec Command="powershell -NoProfile -NoLogo $(SdkGenerateBundlePowershellScript) ^
                      '$(SdkMSIInstallerFile)' ^
                      '$(DownloadsFolder)$(DownloadedAspNetCoreSharedFxWixLibFileName)' ^
                      '$(DownloadsFolder)$(DownloadedSharedFrameworkInstallerFileName)' ^
                      '$(DownloadsFolder)$(DownloadedHostFxrInstallerFileName)' ^
                      '$(DownloadsFolder)$(DownloadedSharedHostInstallerFileName)' ^
                      '$(DownloadsFolder)$(DownloadedWinFormsAndWpfSharedFrameworkInstallerFileName)' ^
                      '$(DownloadsFolder)$(DownloadedNetCoreAppTargetingPackInstallerFileName)' ^
                      '$(DownloadsFolder)$(DownloadedNetStandardTargetingPackInstallerFileName)' ^
                      '$(DownloadsFolder)$(DownloadedNetCoreAppHostPackInstallerFileName)' ^
                      '$(DownloadsFolder)$(DownloadedAlternateNetCoreAppHostPackInstallerFileName)' ^
                      '$(DownloadsFolder)$(DownloadedArmNetCoreAppHostPackInstallerFileName)' ^
                      '$(DownloadsFolder)$(DownloadedArm64NetCoreAppHostPackInstallerFileName)' ^
                      '$(DownloadsFolder)$(DownloadedAspNetTargetingPackInstallerFileName)' ^
                      '$(DownloadsFolder)$(DownloadedWindowsDesktopTargetingPackInstallerFileName)' ^
                      '$(FinalizerExe)' ^
                      '$(LatestTemplateMsiInstallerFile)' ^
                      '$(ManifestsMsiInstallerFile)' ^
                      '$(CombinedFrameworkSdkHostMSIInstallerFile)' ^
                      '$(WixRoot)' ^
                      '$(SdkBrandName)' ^
                      '$(MsiVersion)' ^
                      '$(SDKBundleVersion)' ^
                      '$(Version)' ^
                      '$(MicrosoftWindowsDesktopAppRuntimePackageVersion)' ^
                      '$(CombinedFrameworkSDKHostInstallerUpgradeCode)' ^
                      '$(SdkDependencyKeyName)' ^
                      '$(Architecture)' ^
                      '$(MicrosoftNETCoreAppRuntimePackageVersion)' ^
                      '$(MicrosoftAspNetCoreAppRuntimePackageVersion)' ^
                      '$(CliProductBandVersion)' ^
                      -InformationAction Continue " />

It would be much better to use the built in tasks (and improve them if necessary), for the following reasons:

  • Central versioning of the WiX tooling
  • Automatic light package generation
  • Less custom code.
@michellemcdaniel
Copy link

Just to add to this, also to RPM generation.

@marcpopMSFT marcpopMSFT added this to the 6.0.2xx milestone Sep 23, 2021
@marcpopMSFT marcpopMSFT modified the milestones: 6.0.2xx, backlog Jun 26, 2023
@MiYanni
Copy link
Member

MiYanni commented Jun 10, 2024

@joeloff Is this a reasonable goal to have? If so, we can transfer this issue to dotnet/sdk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants