-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker compose #28
Comments
@jenniferjiangkells do we need this now? Also can we add hacktoberfest label to this issue? |
@TanyaKansal you're welcome to work on this if you want! I will add the label and description |
Thanks |
@TanyaKansal I've updated the description and added it to hacktoberfest. Apologies the sandbox isn't as well documented so please let me know if you have any questions! |
sure, thanks @jenniferjiangkells |
Can I contribute to this issue? |
@jenniferjiangkells please assign this issue to me so that others don't work on it |
@TanyaKansal We don't typically assign issues, your comment lets us and others know that it's already being worked on - just open the PR when you're ready 🙂 @iniminimini It looks like this issue is already being worked on, but you're welcome to take a look at the other open issues to see if there's anything else you'd like to work on! |
Description
Add support to run the sandbox application in a Docker environment
Context
Adding
docker-compose.yml
will help developers quickly set up their environments and ensure consistency across different machines. It will also make it easier to manage dependencies and services required for the application and reduce "it works on my machine" type issues.decorators.py/sandbox
Possible Implementation
Dockerfile
filedocker-compose.yml
, whichsandbox
servicerun_sandbox.py
script as an entrypoint (see example_use.py)Some adjustments to the start_sandbox function may also be needed. Possible changes:
self.service_config
We can introduce a flag e.g.
use_docker
to determine the running environment and adjust the behavior accordingly that users are able to run both locally and using Docker.The text was updated successfully, but these errors were encountered: