-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symlinks aren't followed #45
Comments
Thanks for your feedbak/idea. There are more things to consider:
I would be glad to test if you have a working patched version. |
Done, just sent a pull request. It would be nice to maybe add it as an option instead of hard-coding it. |
Also, regarding circular symlinks: |
Hi, please also consider that current behaviour is in most case more relevant |
I have a directory with a lot of symlinks (both files and dirs), and, when I sync it, the expected behavior would be for the actual file or directory to be synced, not the symlink itself.
rsync
has the-L
flag which does exactly this, so I hope this wouldn't be too hard to implement:In the same way that
bsync
has the-o
flag to pass arguments tossh
, I propose for there to be a similar flag that allows us to pass custom arguments torsync
. However, this would require some further changes: for instance, to the code that generates the.bsync-snap
to account for when we want to follow symlinks (pass the-L
flag tofind
).However, I also had to edit the flags that are currently passed to
rsync
by default, namely-a
which conflicts with-L
. According toman rsync
,-a
is the same as-rlptgoD
, so I just changed-a
to-rLptgoD
to test, and the rsync part worked.The text was updated successfully, but these errors were encountered: