Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialization and update of memory #4

Open
Karamya opened this issue Aug 21, 2019 · 7 comments
Open

Initialization and update of memory #4

Karamya opened this issue Aug 21, 2019 · 7 comments

Comments

@Karamya
Copy link

Karamya commented Aug 21, 2019

Your paper does not discuss about how you initialise the memory and how do you update the memory while training. Can you please share your code for this and refer me to the relevant publication where they discuss about this. Thanks

@h19920918
Copy link

h19920918 commented Aug 22, 2019

When implementing this paper, I used weight parameters for the memory.
It means that the parameters will be updated by the loss during training procedure.
But I'm not sure.

Also, I want to see how to initialize and update the memory.

@Karamya
Copy link
Author

Karamya commented Aug 22, 2019

Thanks @h19920918 , can your reproduce the results for example on MNIST which they show in the paper. If yes, can you share your code

@h19920918
Copy link

I didn't apply their main contribution about Anomaly Detection, just training my network on MNIST dataset.
But when I visualized an image from single memory slot, I couldn't reproduce the results in the paper.

If I finish fixing some bugs, it might be uploaded on my GitHub.

@h19920918
Copy link

h19920918 commented Aug 22, 2019

I uploaded my code for you.

But it's not perfectly implemented.

And you might feel something strange when you watch the code, since it is not main objective to perfectly implement.

@Karamya
Copy link
Author

Karamya commented Aug 22, 2019

Thanks, will have a look 👍

@0merjavaid
Copy link

0merjavaid commented Dec 4, 2019

@h19920918 your code runs smoothly!
thanks man!
and I also feel like the reconstruction from memory index is also decent. the reason it didn't work in your case is that you are training for all digits i.e 0-9. when I trained on just one digit 0 the reconstructions are reasonable(using random idx).

@h19920918
Copy link

@0merjavaid Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants