Error for default settings

[qvipin]

Describe The Problem
A suspected bug when trying to include all ipv6 ips in the default settings

Expected Error / Traceback

Please provide the error traceback here

To Reproduce
enter what I had entered

OS Information:

• Proxmox LXC container using Proxmox VE scripts.

[DaanSelen]

I tried this with the latest code. Could not reproduce.

Can you try again? Or how are you running this?

[qvipin]

On the sidebar when you go to the default settings for all configs not when you create a peer.

…

On Fri, Nov 15, 2024 at 7:12 AM dselen ***@***.***> wrote: I tried this with the latest code. Could not reproduce. image.png (view on web) <https://github.com/user-attachments/assets/2fdaa19a-0250-4431-94db-d7a90e4350dc> Can you try again? Or how are you running this? — Reply to this email directly, view it on GitHub <#490 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BC2GJXNNZX4GNAPXKM6TW5T2AXQMTAVCNFSM6AAAAABRX6HVX6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZYGY4DENBZGI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[DaanSelen]

Can reproduce.

[NOXCIS]

@donaldzou @DaanSelen

Broken Function

def __configValidation

Source of Problem

if key == "peer_endpoint_allowed_ip":
            value = value.split(",")
            for i in value:
                try:
                    ipaddress.ip_network(i, strict=False)
                except Exception as e:
                    return False, str(e)

Fix

if key == "peer_endpoint_allowed_ip":
            value = value.split(",")
            for i in value:
                i = i.strip()  # Remove leading/trailing whitespace
                try:
                    ipaddress.ip_network(i, strict=False)
                except Exception as e:
                    return False, str(e)

Tested Pass Cases

• 0.0.0.0/0
• 0.0.0.0/0, ::/0
• 0.0.0.0/0, ::/0, 192.168.1.1/24

Tested Fail Cases

• 0.0.0.0/04s

'0.0.0.0/04s' does not appear to be an IPv4 or IPv6 network

• 0.0.0.0/0, ::/042s

'::/042s' does not appear to be an IPv4 or IPv6 network

• 0.0.0.0/0s, ::/042

'0.0.0.0/0s' does not appear to be an IPv4 or IPv6 network

[donaldzou]

Hi @NOXCIS, thanks for providing the fix. Will create a PR later to fix this :)