-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use namespace for separator #552
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #552 +/- ##
==========================================
+ Coverage 59.88% 61.39% +1.50%
==========================================
Files 12 12
Lines 1578 1650 +72
==========================================
+ Hits 945 1013 +68
- Misses 633 637 +4 ☔ View full report in Codecov by Sentry. |
A couple of things:
|
@seanthegeek Yeah, somehow I missed the other files, they're in the mail classes, they should be there now. I've updated to get the separator once. |
I have verified that this works in my configuration with Dovecot. The |
- Skip invalid aggregate report rows without calling the whole report invalid - Some providers such as GoDaddy will send reports with some rows missing a source IP address, while other rows are fine - Fix Dovecot support by using the seperator provided by the IPMAP namespace when possible (PR #552 closes #551) - Only download `base_reverse_dns_map.csv` once (fixes #542) - Update included `base_reverse_dns_map.csv` - Replace University category with Education to be more inclusive - Update included `dbip-country-lite.mmdb`
- Fix processing of SMTP-TLS reports (#549) - Skip invalid aggregate report rows without calling the whole report invalid - Some providers such as GoDaddy will send reports with some rows missing a source IP address, while other rows are fine - Fix Dovecot support by using the seperator provided by the IPMAP namespace when possible (PR #552 closes #551) - Only download `base_reverse_dns_map.csv` once (fixes #542) - Update included `base_reverse_dns_map.csv` - Replace University category with Education to be more inclusive - Update included `dbip-country-lite.mmdb`
Use the IMAP namespace separator based on the information retrieved from the IMAP command to retrieve namespaces, falling back to '/' if the command isn't available or the results don't include the private namespace.
Resolves #551