Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'since' option to search for messages since a certain time #527

Merged
merged 10 commits into from
Nov 2, 2024

Conversation

ramspoluri
Copy link
Contributor

  • Added since option under mailbox section to search for messages since a certain time instead of going through the complete mailbox during testing scenarios. Acceptable values -5m|3h|2d|1w, units - {"m":"minutes", "h":"hours", "d":"days", "w":"weeks"}). Defaults to 1d if an incorrect value is provided.
  • Not to mark messages as read if test option is selected (works only for MSGraphConnection)

    - Added `since` option under `mailbox` section to search for messages since a certain time instead of going through the complete mailbox during testing scenarios. Acceptable values -`5m|3h|2d|1w`, units - {"m":"minutes", "h":"hours", "d":"days", "w":"weeks"}). Defaults to `1d` if an incorrect value is provided.
    - Not to mark messages as read if test option is selected (works only for MSGraphConnection)
Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 8.77193% with 52 lines in your changes are missing coverage. Please review.

Project coverage is 58.39%. Comparing base (d6128ea) to head (f618f69).
Report is 22 commits behind head on master.

Files Patch % Lines
parsedmarc/__init__.py 5.88% 32 Missing ⚠️
parsedmarc/mail/graph.py 18.18% 9 Missing ⚠️
parsedmarc/mail/gmail.py 12.50% 7 Missing ⚠️
parsedmarc/mail/imap.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #527      +/-   ##
==========================================
- Coverage   59.88%   58.39%   -1.50%     
==========================================
  Files          12       12              
  Lines        1578     1620      +42     
==========================================
+ Hits          945      946       +1     
- Misses        633      674      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

parsedmarc/__init__.py Outdated Show resolved Hide resolved
parsedmarc/__init__.py Show resolved Hide resolved
@seanthegeek
Copy link
Contributor

@ramspoluri If you address the issues noted by @AnaelMobilia and I I'll merge these changes.

parsedmarc/__init__.py Outdated Show resolved Hide resolved
parsedmarc/__init__.py Outdated Show resolved Hide resolved
parsedmarc/__init__.py Show resolved Hide resolved
@seanthegeek seanthegeek merged commit bd5774d into domainaware:master Nov 2, 2024
seanthegeek added a commit that referenced this pull request Nov 9, 2024
@dwydler
Copy link

dwydler commented Nov 10, 2024

@seanthegeek
The changes for docs/source/usage.md are not yet displayed on https://domainaware.github.io/parsedmarc/.
I suspect you forgot to trigger the "pages-build-deployment" action?!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants