Tomcat 10 support

[ebourg]

tomcatjss doesn't work with Tomcat 10, the build fails with the following errors:

compile:
    [mkdir] Created dir: /build/tomcatjss-8.3.0/build/classes
    [javac] Compiling 8 source files to /build/tomcatjss-8.3.0/build/classes
    [javac] /build/tomcatjss-8.3.0/core/src/main/java/org/dogtagpki/tomcat/Http11NioProtocol.java:110: error: cannot find symbol
    [javac]             setKeystorePass(password);
    [javac]             ^
    [javac]   symbol:   method setKeystorePass(String)
    [javac]   location: class Http11NioProtocol
    [javac] /build/tomcatjss-8.3.0/core/src/main/java/org/dogtagpki/tomcat/Http11NioProtocol.java:121: error: cannot find symbol
    [javac]             setTruststorePass(password);
    [javac]             ^
    [javac]   symbol:   method setTruststorePass(String)
    [javac]   location: class Http11NioProtocol
    [javac] /build/tomcatjss-8.3.0/tomcat-9.0/src/main/java/org/dogtagpki/tomcat/JSSImplementation.java:33: error: JSSImplementation is not abstract and does not override abstract method getSSLSupport(SSLSession,Map<String,List<String>>) in SSLImplementation
    [javac] public class JSSImplementation extends SSLImplementation {
    [javac]        ^
    [javac] /build/tomcatjss-8.3.0/tomcat-9.0/src/main/java/org/dogtagpki/tomcat/JSSImplementation.java:41: error: method does not override or implement a method from a supertype
    [javac]     @Override
    [javac]     ^
    [javac] /build/tomcatjss-8.3.0/tomcat-9.0/src/main/java/org/dogtagpki/tomcat/JSSImplementation.java:61: error: method does not override or implement a method from a supertype
    [javac]     @Override
    [javac]     ^
    [javac] 5 errors

Is there any plan to support Tomcat 10 in the near future?

[ckelleyRH]

Thanks for discovering this issue! We are indeed planning on supporting Tomcat 10 but the time frame is not yet defined.

[tjaalton]

What's the status here?

[ckelleyRH]

What's the status here?

Unchanged. We intend to support it in the future but there is no plan yet.

[tjaalton]

ping again, I need to plan for Ubuntu 24.04 LTS which likely won't have tomcat9 available

[Nihlus]

I've been poking at the source code, and it appears to be relatively trivial to build for Tomcat 10 instead of Tomcat 9. The only real change is that Tomcat 10 no longer provides the setKeystorePass and setTruststorePass methods in AbstractHttp11Protocol<T>.

This change makes setKeystorePassFile and setTruststorePassFile in tomcatjss-core::Http11NioProtocol nonfunctional with (at least to my untrained eyes) no clear replacement.

Beyond that, all that affects tomcatjss is that JSSImplementation::getSSLSupport now has the additionalAttributes map, enabling the forwarding of that argument instead of a null value.

To add my hat into the ring, not having Tomcat 10 support is also a blocker for Debian 13 and a potential backport of the full freeipa server to Debian 12. I have an internal company system that we're currently having to forwardport Tomcat 9 onto Debian 12 for, which isn't ideal.

[tjaalton]

And dogtag is getting kicked out from Ubuntu 24.04 LTS as well. So if you say it's trivial to port, please post patches.

[Nihlus]

I'd need to hear back from the developers about setKeystorePassFile and setTruststorePassFile which I wasn't sure how to deal with - could use another set of eyes on that.

[tjaalton]

send a PR?

[tjaalton]

oh I see, nvm

[tjaalton]

I just realized tomcatjss got merged to jss, so this is not going anywhere here