Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for KRA clone with replicated DS #4652

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

edewata
Copy link
Contributor

@edewata edewata commented Jan 10, 2024

A new test has been added to verify installing CA and KRA subsystem with DS, cloning the CA and KRA databases in DS, then installing CA and KRA clones using the cloned CA and KRA databases.

This process allows DS cloning to be done separately from CA and KRA cloning which could prevent pkispawn from timing out if the database is large.

https://github.com/dogtagpki/pki/wiki/Installing-CA-Clone-with-Replicated-DS
https://github.com/dogtagpki/pki/wiki/Installing-KRA-Clone-with-Replicated-DS

A new test has been added to verify installing CA and KRA
subsystem with DS, cloning the CA and KRA databases in DS,
then installing CA and KRA clones using the cloned CA and
KRA databases.

This process allows DS cloning to be done separately from
CA and KRA cloning which could prevent pkispawn from timing
out if the database is large.

https://github.com/dogtagpki/pki/wiki/Installing-CA-Clone-with-Replicated-DS
https://github.com/dogtagpki/pki/wiki/Installing-KRA-Clone-with-Replicated-DS
@edewata edewata requested a review from fmarco76 January 10, 2024 15:35
Copy link

Copy link
Member

@fmarco76 fmarco76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
The CA clone is already in a different workflow. This duplication is not an isolated case. We should optimise these in future PRs to speed-up the tests

@edewata
Copy link
Contributor Author

edewata commented Jan 11, 2024

@fmarco76 Thanks!

Yes, there's a lot of duplication right now, but it's not easy to create a reusable code for GitHub CI (e.g. objects created in one job cannot be used in another job). If you have some ideas we can certainly discuss it. I'll merge the PR for now.

@edewata edewata merged commit 3b625f2 into dogtagpki:master Jan 11, 2024
132 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants