From 6232c054d0783546be146ee0c6de7d1d99e185a7 Mon Sep 17 00:00:00 2001 From: Christina Fu Date: Wed, 15 Nov 2023 10:07:35 -0800 Subject: [PATCH] Bug2246422 (debug log cleanup)- ServerSideKeygen static SKID This is just a follow-up patch to commit 71bf1619065f6d3b612c0cdd8cd50f958192dba5 to clean up some debug calls. relating to https://bugzilla.redhat.com/show_bug.cgi?id=2246422 --- .../cms/profile/common/CAEnrollProfile.java | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/base/ca/src/main/java/com/netscape/cms/profile/common/CAEnrollProfile.java b/base/ca/src/main/java/com/netscape/cms/profile/common/CAEnrollProfile.java index e48f09e7978..ca6246a7c66 100644 --- a/base/ca/src/main/java/com/netscape/cms/profile/common/CAEnrollProfile.java +++ b/base/ca/src/main/java/com/netscape/cms/profile/common/CAEnrollProfile.java @@ -297,7 +297,7 @@ public void execute(IRequest request) // process certificate issuance X509CertInfo info = request.getExtDataInCertInfo(REQUEST_CERTINFO); - logger.debug(method + "cfu before: X509CertInfo info = " + info.toString()); + // logger.debug(method + " before: X509CertInfo info = " + info.toString()); if (isSSKeygen) { try { @@ -305,7 +305,7 @@ public void execute(IRequest request) if (pubKeyStr == null) { throw new EProfileException("Server-Side Keygen enrollment failed to retrieve public_key from KRA"); } - logger.debug(method + "pubKeyStr = " + pubKeyStr); + // logger.debug(method + "pubKeyStr = " + pubKeyStr); byte[] pubKeyB = CryptoUtil.base64Decode(pubKeyStr); CertificateX509Key certKey = new CertificateX509Key( new ByteArrayInputStream(pubKeyB)); @@ -316,17 +316,17 @@ public void execute(IRequest request) if (infokey != null) { X509Key key = (X509Key) infokey.get(CertificateX509Key.KEY); - logger.debug(method + "key = " + key.toString()); + // logger.debug(method + "key = " + key.toString()); // a placeholder temporary fake key was put in // ServerKeygenUserKeyDefault info.delete(X509CertInfo.KEY); - logger.debug(method + "key deleted"); + // logger.debug(method + "fake key deleted"); } // adding real key info.set(X509CertInfo.KEY, certKey); - // fake key relaced; + // fake key replaced; // need to compute/replace SKI as well if present Extension ext = CertUtils.getExtension(PKIXExtensions.SubjectKey_Id.toString(), info); @@ -344,8 +344,8 @@ public void execute(IRequest request) CertUtils.replaceExtension(PKIXExtensions.SubjectKey_Id.toString(), skiExt, info); logger.debug(method + " SubjectKey_Id replaced"); - logger.debug(method + " after replacement: X509CertInfo info = " + info.toString()); - }/* else + // logger.debug(method + " after replacement: X509CertInfo info = " + info.toString()); + }/* else Not every cert needs an SKI logger.debug(method + "did not find SubjectKey_Id"); */