Make saved annotations filterable and sortable #4887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorg-vr
added
the
enhancement
jorg-vr
requested review from
bmesuere and
niknetniko
and removed request for
a team
niknetniko
requested changes
Aug 16, 2023
bmesuere
approved these changes
Aug 16, 2023
niknetniko
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes saved_annotations sortable and filterable on the list page.
It also contains a new rails concern
sortablethat avoids duplicating complex code fragment for the 4th time.Because of #4886 I could also simplify the
annotations_listcomponent, as the small layout with prefiltering is no longer used.I also updated the table content:
exercise and course no longer link to the item but act as easy filter buttons.
number of usages is a separate column to make it more easily sortable.
fix flickering similar to Update annotation form #4701
Part of #4564