-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use different methods than execute()
when retrieving results
#2689
Conversation
762fee8
to
473e11f
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2689 +/- ##
==========================================
+ Coverage 79.56% 79.61% +0.04%
==========================================
Files 161 161
Lines 8409 8419 +10
==========================================
+ Hits 6691 6703 +12
+ Misses 1718 1716 -2
☔ View full report in Codecov by Sentry. |
2fe7a39
to
5bd3cf2
Compare
execute()
calls with getIterator()
execute()
when retrieving results
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 not sure if you want to merge this one first or #2686
I guess it would be better to merge #2686 first, just in case. |
thanks @phansys! |
This should also contribute reducing the resource consumption where iterators are used instead of arrays.
Calls to
compact()
were also replaced in order to consume the related variables explicitly.