Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cases or early exit with skipping defer #2802

Open
tonistiigi opened this issue Nov 20, 2024 · 0 comments
Open

fix cases or early exit with skipping defer #2802

tonistiigi opened this issue Nov 20, 2024 · 0 comments
Labels
kind/bug Something isn't working
Milestone
v0.20.0

Comments

@tonistiigi
Copy link
Member

There are couple of cases (eg. when using --call check) that do an early return that can skip running defers and (for example reporting metrics).

After fixing https://github.com/docker/buildx/blob/master/.golangci.yml#L38 linter rule should be enabled.
@tonistiigi tonistiigi added the kind/bug Something isn't working label Nov 20, 2024
@crazy-max crazy-max added this to the v0.20.0 milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
v0.20.0
Development

No branches or pull requests
2 participants
@tonistiigi @crazy-max