-
Notifications
You must be signed in to change notification settings - Fork 8
Docfx v3 Open Source Release Prototype #34
Comments
First of all, thank you a ton for the work being done here, this is looking very promising I have a few suggestions for this point:
|
I also think I found an issue with the header links: For the toc links you take into consideration if it is a relative or absolute path. However, it seems like you cannot make absolute paths work in the menu.yml (it doesn't matter if it comes from xref or if it's hardcoded there). In the toc: Line 37 in eb44c92
In the nav: Line 27 in eb44c92
|
Thanks @DavidMarquezF. These are all valuable feedbacks!
I'm thinking about exposing these knobs using CSS variables, which could support a wide range of site visual configurations. It is good know that people wants to customize these tiny details like the warning icon. |
Good idea, I guess CSS variables would allow to customize everything. Regarding the relative path issue i pointed out, do you want me to create a separate issue for it / create a pull request? |
A pull request would be great! |
However, I was thinking not only about being able to style the existing Quote Notes. This is not related to this repository, but since you're involved in both and it also affects the template I'll post this here in order to discuss even if its something in scope. The main problem I see is that the private readonly List<string> _noteTypes = new() { "[!NOTE]", "[!TIP]", "[!WARNING]", "[!IMPORTANT]", "[!CAUTION]" }; It would be nice if the template itself provided these through the context. Then all the templates (no only this one) would have full control over these properties. Maybe adding in the context a variable to specify this list and then take it from there. Also, it would be nice that they could be translated to other languages. Looking at the docfx source it looks like this should be added inside ContentTemplate/token.. Is this something the template is going to provide or the users should do it? |
This one needs an issue in https://github.com/dotnet/docfx. It is more than just a template change. |
Will do :) |
Why do you remove HUB page from TODOList ? |
Track the progress of docfx v3 open-source release prototype. The prototype is intended to include these essential functionalities to build a static .NET API reference website:
csproj
files will not be part of this prototype.Dogfood
Run the prototype against these Open Source .NET Foundation Projects, finding bugs and feature gaps:
.NET API Reference Pipeline
docfx build
triggers .NET API reference pipelineSite Template Customization
Hub pageFinalize page visualMisc
Additional Features
Additional features that are not part of this prototype but should be considered at a later stage:
docfx serve
watch content changesThe text was updated successfully, but these errors were encountered: