Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement grpc client #48

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

Roxxas96
Copy link

@Roxxas96 Roxxas96 commented Aug 17, 2022

Close #45

Overall explanation of your work :

This PR implements a gRPC client interface used to communicate with the kudo-scheduler gRPC interface. This interface implement all procedures listed in the scheduler's .proto.

Technical decisions you've made and why :

  • I used tonic gRPC client because we already chose the tonic's server library to crete our own server.

Tasks lists :

  • Implement the base interface
  • Implement all procedures listed in kudo-scheduler .proto

@Roxxas96 Roxxas96 added enhancement New feature or request team/cluster-controller Relative to cluster-controller team project-pr labels Aug 17, 2022
@Roxxas96 Roxxas96 requested review from GridexX and Maxtho8 August 17, 2022 15:35
@Roxxas96 Roxxas96 self-assigned this Aug 17, 2022
@Roxxas96 Roxxas96 linked an issue Aug 17, 2022 that may be closed by this pull request
1 task
@Roxxas96 Roxxas96 changed the base branch from main to team/cluster-controller August 17, 2022 15:42
@Roxxas96 Roxxas96 marked this pull request as ready for review August 17, 2022 15:48
GridexX
GridexX previously approved these changes Aug 20, 2022
@Roxxas96 Roxxas96 force-pushed the 45-feat-implement-grpc-client branch 5 times, most recently from 8ee3cab to 581e881 Compare August 20, 2022 19:50
@Roxxas96 Roxxas96 force-pushed the team/cluster-controller branch from 6c536d6 to 225a53a Compare August 20, 2022 19:52
@Roxxas96 Roxxas96 force-pushed the 45-feat-implement-grpc-client branch 5 times, most recently from 4e99371 to a78a52e Compare August 23, 2022 15:49
Signed-off-by: Alexandre Gomez <[email protected]>
@Roxxas96 Roxxas96 force-pushed the 45-feat-implement-grpc-client branch from a78a52e to 62f91da Compare August 23, 2022 15:51
@Roxxas96 Roxxas96 merged commit 169fa61 into team/cluster-controller Aug 23, 2022
@Roxxas96 Roxxas96 deleted the 45-feat-implement-grpc-client branch August 23, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request project-pr team/cluster-controller Relative to cluster-controller team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: implement grpc client
2 participants