Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: update only #3

Closed
irsdl opened this issue Feb 8, 2016 · 4 comments
Closed

Feature request: update only #3

irsdl opened this issue Feb 8, 2016 · 4 comments

Comments

@irsdl
Copy link

irsdl commented Feb 8, 2016

I need to use this extension only to update the requests that already have OAuth header. That would be great if we could have an option in a config file to enable or disable this.

@dnet
Copy link
Owner

dnet commented Feb 8, 2016

Sounds nice, would you like to provide the patch?

@dnet
Copy link
Owner

dnet commented Feb 8, 2016

Longer version: it looks like the Signpost library reuses the header if one is already defined, so I'm not sure you'd like this functionality, as it'd mean reusing nonces, (most probably) resulting in rejected requests. So it's not as simple as adding an if (OAuthConfig.updateOnly) { ... }, thus I'm not really motivated right now to solve this, but if anyone offers a patch, I'd be happy to review and quite possibly merge it.

@dnet dnet closed this as completed Feb 8, 2016
@irsdl
Copy link
Author

irsdl commented Feb 8, 2016

At the moment, when it sees the authorization header, it just ignores it. It should update it instead.

@dnet
Copy link
Owner

dnet commented Feb 9, 2016

It doesn't ignore it, it signs with the same parameters (including nonce), resulting in the same signature. Since this is similar to #1, this discussion should be continued there; see my comment there with the three item list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants