From f7cb377636e64cae73f958ee98e3ad394f92a83f Mon Sep 17 00:00:00 2001
From: Colin Murtaugh <cmurtaugh@gmail.com>
Date: Tue, 14 Feb 2023 11:35:02 -0500
Subject: [PATCH 1/8] Added iframe support to DeepLinkResource

---
 pylti1p3/deep_link_resource.py | 11 +++++++++++
 tests/test_deep_link.py        |  3 ++-
 2 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/pylti1p3/deep_link_resource.py b/pylti1p3/deep_link_resource.py
index 131606f..e3c2103 100644
--- a/pylti1p3/deep_link_resource.py
+++ b/pylti1p3/deep_link_resource.py
@@ -8,6 +8,7 @@ class DeepLinkResource:
     _url: t.Optional[str] = None
     _lineitem: t.Optional[LineItem] = None
     _custom_params: t.Mapping[str, str] = {}
+    _iframe: t.Mapping[str, int] = {}
     _target: str = "iframe"
     _icon_url: t.Optional[str] = None
 
@@ -60,6 +61,13 @@ def set_icon_url(self, value: str) -> "DeepLinkResource":
         self._icon_url = value
         return self
 
+    def get_iframe(self) -> t.Mapping[str, int]:
+        return self._iframe
+
+    def set_iframe(self, value: t.Mapping[str, int]):
+        self._iframe = value
+        return self
+
     def to_dict(self) -> t.Dict[str, object]:
         res: t.Dict[str, object] = {
             "type": self._type,
@@ -93,4 +101,7 @@ def to_dict(self) -> t.Dict[str, object]:
         if self._icon_url:
             res["icon"] = {"url": self._icon_url}
 
+        if self._iframe:
+            res["iframe"] = self._iframe
+
         return res
diff --git a/tests/test_deep_link.py b/tests/test_deep_link.py
index d9a3083..37361fe 100644
--- a/tests/test_deep_link.py
+++ b/tests/test_deep_link.py
@@ -160,13 +160,14 @@ def test_deep_link_launch_success(self):
         resource = DeepLinkResource()
         resource.set_url("http://lti.django.test/launch/").set_custom_params(
             {"custom_param": "custom_value"}
-        ).set_title("Test title!")
+        ).set_title("Test title!").set_iframe({"width": 800, "height": 400})
 
         deep_link_return_url = message_launch_data.get(
             "https://purl.imsglobal.org/spec/lti-dl/claim/deep_linking_settings"
         ).get("deep_link_return_url")
 
         html = validated_message_launch.get_deep_link().output_response_form([resource])
+        print(html)
         self.assertTrue(
             html.startswith(
                 f'<form id="lti13_deep_link_auto_submit" action="{deep_link_return_url}" '

From d3a6f3e49b2108a092731451392380f410f26625 Mon Sep 17 00:00:00 2001
From: Colin Murtaugh <cmurtaugh@gmail.com>
Date: Tue, 14 Feb 2023 12:39:06 -0500
Subject: [PATCH 2/8] fixed code formatting errors caught by black

---
 .../contrib/django/lti1p3_tool_config/migrations/0001_initial.py | 1 -
 pylti1p3/deployment.py                                           | 1 -
 tests/test_resource_link.py                                      | 1 -
 3 files changed, 3 deletions(-)

diff --git a/pylti1p3/contrib/django/lti1p3_tool_config/migrations/0001_initial.py b/pylti1p3/contrib/django/lti1p3_tool_config/migrations/0001_initial.py
index 625e129..0b850b8 100644
--- a/pylti1p3/contrib/django/lti1p3_tool_config/migrations/0001_initial.py
+++ b/pylti1p3/contrib/django/lti1p3_tool_config/migrations/0001_initial.py
@@ -5,7 +5,6 @@
 
 
 class Migration(migrations.Migration):
-
     initial = True
 
     dependencies = []
diff --git a/pylti1p3/deployment.py b/pylti1p3/deployment.py
index cfbbf9b..2cceb94 100644
--- a/pylti1p3/deployment.py
+++ b/pylti1p3/deployment.py
@@ -2,7 +2,6 @@
 
 
 class Deployment:
-
     _deployment_id: t.Optional[str] = None
 
     def get_deployment_id(self) -> t.Optional[str]:
diff --git a/tests/test_resource_link.py b/tests/test_resource_link.py
index cb669c4..85477fa 100644
--- a/tests/test_resource_link.py
+++ b/tests/test_resource_link.py
@@ -299,7 +299,6 @@ def _get_data_with_invalid_message(self, *args):  # pylint: disable=unused-argum
         return message_launch_data
 
     def test_res_link_launch_invalid_nonce(self):
-
         tool_conf, login_request, login_response = self._make_oidc_login()
 
         post_data = self.post_launch_data.copy()

From c2a073fce90ad73f6cbf82ed7df16c7807a5ffe7 Mon Sep 17 00:00:00 2001
From: Colin Murtaugh <cmurtaugh@gmail.com>
Date: Tue, 14 Feb 2023 12:39:31 -0500
Subject: [PATCH 3/8] pin pylint to 2.15.6

---
 tox.ini | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tox.ini b/tox.ini
index 51058bd..42a9aac 100644
--- a/tox.ini
+++ b/tox.ini
@@ -20,7 +20,7 @@ deps =
     mypy
     parameterized
     pyjwt
-    pylint
+    pylint==2.15.6
     requests
     requests-mock
     types-requests

From 923d3ab489a4a758a5ae3595410d58f4009b0508 Mon Sep 17 00:00:00 2001
From: Colin Murtaugh <colin_murtaugh@harvard.edu>
Date: Tue, 14 Feb 2023 12:48:26 -0500
Subject: [PATCH 4/8] Update checkout and setup-python action versions

Update `checkout` and `setup-python` actions to latest versions.
---
 .github/workflows/tox.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/tox.yml b/.github/workflows/tox.yml
index b59bdc2..448593f 100644
--- a/.github/workflows/tox.yml
+++ b/.github/workflows/tox.yml
@@ -9,8 +9,8 @@ jobs:
         python: ['3.6', '3.7', '3.8', '3.9', '3.10', '3.11']
     runs-on: ${{ matrix.os }}
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-python@v3
+      - uses: actions/checkout@v3.3.0
+      - uses: actions/setup-python@v4.5.0
         with:
           python-version: ${{ matrix.python }}
       - run: pip install --upgrade pip

From 9364833004effddbaff73ab9e749f22a61820954 Mon Sep 17 00:00:00 2001
From: Colin Murtaugh <colin_murtaugh@harvard.edu>
Date: Tue, 14 Feb 2023 12:58:25 -0500
Subject: [PATCH 5/8] Run tests on ubuntu-20.04 since python 3.6 isn't
 available in ubuntu-latest (22.04)

---
 .github/workflows/tox.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/tox.yml b/.github/workflows/tox.yml
index 448593f..18aa5b1 100644
--- a/.github/workflows/tox.yml
+++ b/.github/workflows/tox.yml
@@ -5,7 +5,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu-latest]
+        os: [ubuntu-20.04]
         python: ['3.6', '3.7', '3.8', '3.9', '3.10', '3.11']
     runs-on: ${{ matrix.os }}
     steps:

From 4e010da1d64a050b2e87e9eb6767854b7f665f3c Mon Sep 17 00:00:00 2001
From: Colin Murtaugh <colin_murtaugh@harvard.edu>
Date: Tue, 14 Feb 2023 13:01:35 -0500
Subject: [PATCH 6/8] Removed pylint 2.15.6 version requirement since it's not
 available for ubuntu-20.04

---
 tox.ini | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tox.ini b/tox.ini
index 42a9aac..51058bd 100644
--- a/tox.ini
+++ b/tox.ini
@@ -20,7 +20,7 @@ deps =
     mypy
     parameterized
     pyjwt
-    pylint==2.15.6
+    pylint
     requests
     requests-mock
     types-requests

From 1b9da10c18bbc49b48415cac7a4548c671fedb8f Mon Sep 17 00:00:00 2001
From: Colin Murtaugh <colin_murtaugh@harvard.edu>
Date: Tue, 14 Feb 2023 13:06:03 -0500
Subject: [PATCH 7/8] try pinning pylint<2.15.6

---
 tox.ini | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tox.ini b/tox.ini
index 51058bd..e25a59d 100644
--- a/tox.ini
+++ b/tox.ini
@@ -20,7 +20,7 @@ deps =
     mypy
     parameterized
     pyjwt
-    pylint
+    pylint<2.15.6
     requests
     requests-mock
     types-requests

From dbc3f1a0e53b87d4c13d3856c8a27780fdf4d5ba Mon Sep 17 00:00:00 2001
From: Colin Murtaugh <cmurtaugh@gmail.com>
Date: Tue, 14 Feb 2023 14:14:13 -0500
Subject: [PATCH 8/8] removed debugging line

---
 tests/test_deep_link.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/test_deep_link.py b/tests/test_deep_link.py
index 37361fe..287fa6b 100644
--- a/tests/test_deep_link.py
+++ b/tests/test_deep_link.py
@@ -167,7 +167,6 @@ def test_deep_link_launch_success(self):
         ).get("deep_link_return_url")
 
         html = validated_message_launch.get_deep_link().output_response_form([resource])
-        print(html)
         self.assertTrue(
             html.startswith(
                 f'<form id="lti13_deep_link_auto_submit" action="{deep_link_return_url}" '