Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeepLinkResource always containing an empty object for custom_params leads to issues with Moodle #140

Open
mst-kialo opened this issue Aug 6, 2024 · 1 comment

Comments

@mst-kialo
Copy link

Hello,

thank you for your work on pylti1.3.
We have noticed that the DeepLinkResource sets an empty object as default for _custom_params.
This however seems to lead to issues with Moodle as apparently it cannot deal with empty objects in the custom_params claim. As far as we are aware that claim is optional as per the spec. Is there a specific reason why it is not simply set to None as default?

@hmoffatt
Copy link
Contributor

hmoffatt commented Aug 7, 2024

I have a pull request for this here: #113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants