New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generates invalid auth login URLs #136

Open

hmoffatt opened this issue Jun 17, 2024 · 0 comments · May be fixed by #137

Contributor

hmoffatt commented Jun 17, 2024

In oidc_login.py the auth URL is generated by appending the parameters to the auth URL,

        auth_login_return_url = auth_login_url + "?" + urlencode(auth_params)

but if the auth URL already contains ? then this generates an invalid URL.

The tool consumer https://wordpress.org/support/plugin/lti-platform/ uses an auth URL that is https://domainname.com/?lti-platform&auth so the generated URLs are invalid for this consumer.

The text was updated successfully, but these errors were encountered:

hmoffatt linked a pull request

that will close this issue

handle auth URL already containing query part #137

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment