Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blur overlay is a bit laggy on iPhone 4 and iPhone 4S #24

Open
dmitric opened this issue Nov 20, 2012 · 4 comments
Open

Blur overlay is a bit laggy on iPhone 4 and iPhone 4S #24

dmitric opened this issue Nov 20, 2012 · 4 comments

Comments

@dmitric
Copy link
Owner

dmitric commented Nov 20, 2012

I've recently added in a radial gradient overlay to show the user where the blur is on the screen.
It's done using CoreGraphics and the code can be seen in the drawRect method of BlurOverlayView.m.

I've noticed it's a bit laggy on iPhone 4 and 4S, so if anyone with some CoreGraphics foo would mind helping out, I'd appreciate it.

@leejunkit
Copy link

I solved this by making the BlurOverlayView double the size of the frame, put it in a UIScrollView, and manipulated the scroll view on panning and zooming instead of re-rendering the radial overlay instead. Only when I detect that the pan/pinch has ended from the gesture recognizers then do I call [staticPicture processImage].

Let me know if you would like a proper pull request.

@dmitric
Copy link
Owner Author

dmitric commented Dec 5, 2012

Yeah I'll take a look at your branch, thanks!

@dmitric
Copy link
Owner Author

dmitric commented Dec 7, 2012

@leejunkit so I took a look at it, and it's definitely faster, but it doesn't feel or look as nice as the current version. Thanks the great idea though. I may borrow from some of your code when I revisit this.

@leejunkit
Copy link

Sure. You're welcome! :)

Sent from my iPhone

On 7 Dec, 2012, at 9:37 AM, Dmitri Cherniak [email protected] wrote:

@leejunkit so I took a look at it, and it's definitely faster, but it doesn't feel or look as nice as the current version. Thanks the great idea though. I may borrow from some of your code when I revisit this.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants