Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: apply wrapping with lipgloss #466

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: apply wrapping with lipgloss #466

wants to merge 1 commit into from
+3 −1

Conversation

Garfeild
Copy link

@Garfeild Garfeild commented Oct 17, 2024 •
edited
Loading

Summary

This pull request should close #412. Changes are based on suggestion from developers of bubbles in the raised PR charmbracelet/bubbles#578.

How did you test this change?

I tried to replicate initial issue in my private repo. It seems to be rendered correctly after changes. Also, I have checked with my work environment as we usually have lengthy reports from CI and gh-dash is frequently broken.

Images/Videos

Before

Screen.Recording.2024-10-17.at.18.47.50.mov

After

Screen.Recording.2024-10-17.at.18.44.12.mov

@Garfeild Garfeild mentioned this pull request Oct 17, 2024
Open
@Hussain84841411
Copy link

#Garfeild:fix/render-content-with-long-lines

@dlvhdr
Copy link
Owner

dlvhdr commented Nov 4, 2024

Thanks for tackling this @Garfeild!
I think the fix I would like for this is to wrap the entire pill onto the next line.
That way the background would not be broken. This can be checked by doing some basic calculations and then appending a newline if it wraps.
WDYT?

@Garfeild
Copy link
Author

Garfeild commented Nov 4, 2024 •
edited
Loading

Hey! Thanks for review. I will check it, I also noticed that it doesn't fix issue for my work account PRs (we have quite amount of spam from CI).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OGCJM11 OGCJM11 OGCJM11 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] The sidebar does not render all the contents if the content includes a very long line
4 participants
@Garfeild @Hussain84841411 @dlvhdr @OGCJM11