Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Url are feature is not working #1

Closed
CHANDRASEKHAR613 opened this issue Mar 29, 2024 · 3 comments
Closed

Multiple Url are feature is not working #1

CHANDRASEKHAR613 opened this issue Mar 29, 2024 · 3 comments

Comments

@CHANDRASEKHAR613
Copy link

As mentioned in the documentation, Each URL is added on a new line. but indexing for only one URL.

Example:
When I added 5 URLs in the urls.txt, but indexing for 5th URL only, remaining 1to 4 URLs are skipped

@dllpl
Copy link
Owner

dllpl commented Apr 5, 2024

Thanks, I'm already working on it.

@dllpl
Copy link
Owner

dllpl commented Apr 5, 2024

As mentioned in the documentation, Each URL is added on a new line. but indexing for only one URL.

Example: When I added 5 URLs in the urls.txt, but indexing for 5th URL only, remaining 1to 4 URLs are skipped

It works. Here is an example of a successful response from Google about adding 5 URLs to the indexing queue. If you get the same response from your links, then the library has done its job!

But Google may indeed not index your pages for some of its internal reasons: See https://developers.google.com/search/docs/fundamentals/get-on-google#do-you-serve-high-quality-content-to-users

Google may not have liked the quality of pages 1-4, but it liked page 5.

{
    "response-1410898662": {
        "urlNotificationMetadata": {
            "url": "https://grand-service.su/",
            "latestUpdate": {
                "notifyTime": "2024-04-05T12:50:44.043333568Z",
                "type": "URL_UPDATED",
                "url": "https://grand-service.su/"
            }
        }
    },
    "response-1549321495": {
        "urlNotificationMetadata": {
            "url": "https://grand-service.su/remont-televizorov/bang-and-olufsen",
            "latestUpdate": {
                "notifyTime": "2024-04-05T12:50:44.047527414Z",
                "type": "URL_UPDATED",
                "url": "https://grand-service.su/remont-televizorov/bang-and-olufsen"
            }
        }
    },
    "response-1578195267": {
        "urlNotificationMetadata": {
            "url": "https://grand-service.su/remont-duhovyh-shkafov/kitfort",
            "latestUpdate": {
                "notifyTime": "2024-04-05T12:50:44.042969840Z",
                "type": "URL_UPDATED",
                "url": "https://grand-service.su/remont-duhovyh-shkafov/kitfort"
            }
        }
    },
}

@dllpl dllpl closed this as completed Apr 5, 2024
@dllpl dllpl pinned this issue Apr 6, 2024
@CHANDRASEKHAR613
Copy link
Author

Hello @dllpl,

Upon debugging, I discovered that $response = $batch->execute(); will only occur for the last URL, as it lies outside the foreach loop. I've submitted a PR addressing this issue. Kindly review and consider the matter.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants