Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: The dlang-bot doesn't Resolve Issues whose PRs Target the table branch #296

Open
RubyTheRoobster opened this issue Aug 17, 2022 · 1 comment
Open

BUG: The dlang-bot doesn't Resolve Issues whose PRs Target the table branch #296

RubyTheRoobster opened this issue Aug 17, 2022 · 1 comment

Comments

@RubyTheRoobster
Copy link

Issue #23291 was automatically marked as RESOLVED FIXED by the bot when its PR was merged, in addition to a message being posted by the bot about its being merged.

Meanwhile, for issue #23140, the bot mentioned the PR (which targeted stable) being opened, but never posted when the PR was merged, and I had to manually mark it as RESOLVED FIXED.
This is clearly a bug.
@CyberShadow
Copy link
Member

Yes, but unfortunately the bug is in GitHub.

Sometimes, GitHub delivers notifications for events before they "happen". Meaning, it tells the bot that something changed (e.g. a PR has been created), but when the bot asks GitHub for information about the PR, GitHub replies that no such PR exists.

We probably need to add a workaround for this, e.g. sleeping a few seconds to allow GitHub's parts to catch up with themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CyberShadow @RubyTheRoobster