Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to change flip from left/right to top/bottom #13

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

sukov
Copy link

@sukov sukov commented Dec 2, 2017

No description provided.

@djk12587
Copy link
Owner

djk12587 commented Dec 2, 2017

Kick ass work dude! I'll check out these changes.

I don't use this library personally in any project anymore, which is why it has never received any love or refactoring ever. I always wanted to refactor everything from scratch, as I am not a big fan of my implementation, but I just don't have the time.

@sukov
Copy link
Author

sukov commented Dec 3, 2017

Thank you.

I refactored most of the code, but the massive DJKFlipperView needs a lot more refactoring since it's very confusing when a function for example setUpForFlip calls performFlipWithDJKAnimationLayer at the end.

@sukov
Copy link
Author

sukov commented Dec 3, 2017

Just a random question, is there any other way of doing this interactive animation beside from using CATransform3DIdentity and CATransaction ?

@djk12587
Copy link
Owner

djk12587 commented Dec 4, 2017

Just a random question, is there any other way of doing this interactive animation beside from using CATransform3DIdentity and CATransaction ?

I think I originally used that because the views are being split in half for the animation layer and static layers. It would be nice to ditch all the layer stuff and just deal with the views, but idk how you can split a uiview in half and manipulate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants