Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added supported wallets to connect function #147

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Added supported wallets to connect function #147

merged 3 commits into from
Oct 31, 2024

Conversation

0xNgoo
Copy link
Contributor

@0xNgoo 0xNgoo commented Oct 30, 2024

Fixes #146

@0xNgoo
Copy link
Contributor Author

0xNgoo commented Oct 30, 2024

Screenshot from 2024-10-30 09-48-33

@0xNgoo
Copy link
Contributor Author

0xNgoo commented Oct 30, 2024

Here @djeck1432

Please review.

@djeck1432 djeck1432 self-requested a review October 30, 2024 08:49
djeck1432
djeck1432 approved these changes Oct 30, 2024
View reviewed changes
Copy link
Owner

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@djeck1432
Copy link
Owner

djeck1432 commented Oct 30, 2024 •
edited
Loading

Please, fix issues with test cases @SailorJhay , I can't merge it until pipeline won't be passed

@djeck1432
Copy link
Owner

Screenshot 2024-10-30 at 10 02 08 @SailorJhay It should be green everywhere

@djeck1432
Copy link
Owner

@SailorJhay Any updates?

djeck1432
djeck1432 requested changes Oct 30, 2024
View reviewed changes
Copy link
Owner

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, fix pipelines

@whateverfw whateverfw self-requested a review October 30, 2024 12:51
@djeck1432 djeck1432 removed the request for review from whateverfw October 30, 2024 14:10
@djeck1432
Copy link
Owner

@SailorJhay Fix please test cases, otherwise you will get partially reward

@0xNgoo
Copy link
Contributor Author

0xNgoo commented Oct 30, 2024

Ok doing that now, sorry didn't see this.

@0xNgoo
Copy link
Contributor Author

0xNgoo commented Oct 30, 2024

Once again, I am sorry for my responsiveness.

@djeck1432 djeck1432 merged commit a372950 into djeck1432:main Oct 31, 2024
3 checks passed
djeck1432
djeck1432 reviewed Oct 31, 2024
View reviewed changes
Copy link
Owner

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APproved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djeck1432 djeck1432 djeck1432 requested changes

Assignees

@0xNgoo 0xNgoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable unused wallets on Frontend
2 participants
@0xNgoo @djeck1432