Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for smart contract #83

Closed
djeck1432 opened this issue Oct 23, 2024 · 12 comments
Closed

Add test cases for smart contract #83

djeck1432 opened this issue Oct 23, 2024 · 12 comments
Assignees
Labels

Comments

@djeck1432
Copy link
Owner

  1. Read guideline here
  2. Set up the project, read README.md how to do that.
  3. Book to help you here
  4. Create test cases for positive and negative scenarios for:
@djeck1432
Copy link
Owner Author

@Mystic-Nayy Please, read first guideline

@codeZe-us
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Mid level Cairo Developer

How I plan on tackling this issue

I like orange

I will set up the contract state with required parameters then invoke the loop_liquidity function with sample deposit data and assert that the position is successfully opened.Also, events like LiquidityLooped will be emitted with correct amounts and token addresses.

@PoulavBhowmick03
Copy link
Contributor

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I'm Poulav Bhowmick, a software engineer at Invisible Studios with a robust background in TypeScript, Rust, Solidity Cairo, fullstack development and blockchain technology. My experience includes building robust applications, optimizing functionalities and blockchain integration. I have actively participated in events and open source contributions, enhancing my capability to tackle real-world tech challenges. My projects can be viewed on my GitHub Profile and OnlyDust Profile. Plus I´m active member of Starknet, Ethereum ecosystem.

How I plan on tackling this issue

I like orange

@faurdent
Copy link
Collaborator

Hi @codeZe-us! Before starting, could you please take a look at this pr. It's still under review and I've already introduced some test cases, just so we won't repeat each other. Thanks!

@codeZe-us
Copy link

codeZe-us commented Oct 24, 2024

!

Okay. I will do that right now

@codeZe-us
Copy link

Hi @codeZe-us! Before starting, could you please take a look at this pr. It's still under review and I've already introduced some test cases, just so we won't repeat each other. Thanks!

You did not write test for Deposit

@faurdent
Copy link
Collaborator

faurdent commented Oct 24, 2024

Hi @codeZe-us! Before starting, could you please take a look at this pr. It's still under review and I've already introduced some test cases, just so we won't repeat each other. Thanks!

You did not write test for Deposit

Check this file, please, it has wrong naming, my bad, but contains tests for Deposit contract

@codeZe-us
Copy link

Hi @codeZe-us! Before starting, could you please take a look at this pr. It's still under review and I've already introduced some test cases, just so we won't repeat each other. Thanks!

You did not write test for Deposit

Check this file, please, it has wrong naming, my bad, but contains tests for Deposit contract

Yeah,seen. @djeck1432 this task has been done. Should i go ahead with it?

@djeck1432
Copy link
Owner Author

@codeZe-us Please ,text me in telegram djeck_vorobey1 and attach this link to this issue in your message

@djeck1432 djeck1432 removed the ODHack9 label Oct 26, 2024
@djeck1432
Copy link
Owner Author

Close this issue as duplicated

@codeZe-us
Copy link

@codeZe-us Please ,text me in telegram djeck_vorobey1 and attach this link to this issue in your message

Ok

@codeZe-us
Copy link

@codeZe-us Please ,text me in telegram djeck_vorobey1 and attach this link to this issue in your message

Please text me. I can't send you text due to my region/location.
CodeZe_us

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants