Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update messages to reflect current state of the translations #1751

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marksweb
Copy link
Contributor

@marksweb marksweb commented Nov 19, 2024

This is a simple makemessages --all to update the .po files to reflect the recently merged translation branches.

I'll run another of these when the remaining branches are merged, but I've made contact with Claude so I think it's worth having some refreshed files to see if they feed in to the current transifex project.


I'm now a transifex maintainer and can see the repo is not integrated to the project there.
I think this is a worthwhile thing to do so we don't need to sync files another way. But I think that'll require someone with repo or org admin on here, because it requires settings access.

@marksweb marksweb requested a review from a team November 19, 2024 14:20
@bmispelon
Copy link
Member

I'm afraid nobody is going to really be reviewing a +20k -/ 500 pull request 😅

What kind of feedback are you after?

One question I had is what the criteria is/was for the list of languages that are included: english, french, indonesian, polish, and portuguese (brazilian)?

@marksweb
Copy link
Contributor Author

marksweb commented Nov 20, 2024

@bmispelon I'm not expecting anybody to review. But we need to generate these files and a PR is the way to get changes in.

This is just django doing django's thing. And at this point the languages offered aren't so important because we're not putting them out as options to users.

The languages on offer here is an interesting question. The project doesn't actually define a LANGUAGES setting which is where it would normally decide on what it was going to make. But that's less important here. I'm essentially looking to get the ball rolling on translations in transifex. If we've got new po files then they should feed in to there.

Once we've got a pipeline to transifex I think then we review the languages on offer. I've already seen the transifex project and the list is vast.

@bmispelon
Copy link
Member

This is just django doing django's thing. And at this point the languages offered aren't so important because we're not putting them out as options to users.

Our deployment script automatically runs compilemessages, doesn't that mean that Django will automatically start offering translated content to users based on their Accept-Language header since we use (a variant of) LocaleMiddleware [1]?

[1] https://github.com/django/djangoproject.com/blob/main/djangoproject/settings/common.py#L149

@marksweb
Copy link
Contributor Author

marksweb commented Nov 21, 2024

@bmispelon Yeah, compilemessages messages is the one you want to run during deployment. That gets the .po files and compiles the .mo files that are then used to serve the translated content.

What I'm trying to do with this is update those .po files that the deployment process would use for translation.

It's a development task rather than ops/deployment because it needs to happen as strings in the application change which is obviously what we've been doing lately. It's makemessages that will also feed content into transifex, making new/changed strings available to the translation teams.

The current deployments might compilemessages on the current .po files but those strings might no longer exist within the application because there hasn't been a makemessages process in a while to update the message catalog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants