Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ANSI color control sequences should optionally be scrubbed from shell completions #144

Open
bckohan opened this issue Nov 20, 2024 · 1 comment
Open

ANSI color control sequences should optionally be scrubbed from shell completions #144

bckohan opened this issue Nov 20, 2024 · 1 comment
Assignees
@bckohan
Labels
enhancement New feature or request
Milestone
Version 3.0

Comments

@bckohan
Copy link
Member

bckohan commented Nov 20, 2024

As of typer 0.13.1 ansi color code sequences appear in shell completions sometimes. Zshell, fish and powershell have good support for this in shell completions but bash support is shaky and the codes may render literally.

shellcompletion complete should honor the --no-color flag and this should be enabled by default in the bash installation scripts. Installation should also toggle --no-color usage on/off based on if the parameter was supplied during install.
@bckohan bckohan self-assigned this Nov 20, 2024
@bckohan bckohan added the enhancement New feature or request label Nov 20, 2024
@bckohan bckohan added this to the Version 3.0 milestone Nov 20, 2024
@bckohan bckohan changed the title ANSI color control sequences should optionally be scrubbed from ANSI color control sequences should optionally be scrubbed from shell completions Nov 20, 2024
@bckohan
Copy link
Member Author

bckohan commented Nov 21, 2024

This issue might be blocked by a solution for #19

bckohan added a commit that referenced this issue Nov 21, 2024
@bckohan
fix #144
880ca14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bckohan bckohan

Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 3.0
Development

When branches are created from issues, their pull requests are automatically linked.

v3 django-commons/django-typer
1 participant
@bckohan